All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark McLoughlin <markmc@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: add msi support.
Date: Mon, 07 Sep 2009 18:57:38 +0100	[thread overview]
Message-ID: <1252346258.3056.73.camel@blaa> (raw)
In-Reply-To: <1250074044-24667-1-git-send-email-kraxel@redhat.com>

On Wed, 2009-08-12 at 12:47 +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/pc.c         |    4 ++++
>  hw/virtio-pci.c |    8 ++++++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pc.c b/hw/pc.c
> index cc6e7e8..cccb865 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1487,6 +1487,10 @@ static QEMUMachine pc_machine_v0_10 = {
>              .driver   = "virtio-net-pci",
>              .property = "vectors",
>              .value    = stringify(0),
> +        },{
> +            .driver   = "virtio-blk-pci",
> +            .property = "vectors",
> +            .value    = stringify(0),

This means that MSI is enabled for virtio-blk with the pc-0.11 machine
type.

Shouldn't we add a pc-0.12 machine type and disable MSI for pc-0.11?

Cheers,
Mark.

  parent reply	other threads:[~2009-09-07 17:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-12 10:47 [Qemu-devel] [PATCH] virtio-blk: add msi support Gerd Hoffmann
2009-08-12 21:57 ` Christoph Hellwig
2009-09-07 17:57 ` Mark McLoughlin [this message]
2009-09-08  6:39   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252346258.3056.73.camel@blaa \
    --to=markmc@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.