From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ml2BK-0008GG-EK for mharc-grub-devel@gnu.org; Tue, 08 Sep 2009 11:00:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ml2BJ-0008Fc-2i for grub-devel@gnu.org; Tue, 08 Sep 2009 11:00:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ml2BE-0008BX-EQ for grub-devel@gnu.org; Tue, 08 Sep 2009 11:00:28 -0400 Received: from [199.232.76.173] (port=60131 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ml2BE-0008BQ-99 for grub-devel@gnu.org; Tue, 08 Sep 2009 11:00:24 -0400 Received: from moutng.kundenserver.de ([212.227.126.177]:53879) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ml2BD-0002L1-JB for grub-devel@gnu.org; Tue, 08 Sep 2009 11:00:24 -0400 Received: from [85.180.10.126] (e180010126.adsl.alicedsl.de [85.180.10.126]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MKv5w-1Ml2B93ZPL-0004fP; Tue, 08 Sep 2009 17:00:20 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20090908144952.GD13674@thorin> References: <1252260211.3895.79.camel@fz.local> <20090908144952.GD13674@thorin> Content-Type: text/plain Date: Tue, 08 Sep 2009 17:00:18 +0200 Message-Id: <1252422018.2872.6.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.27.91 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/7ekeFzIHkOpldFkNVbJs3FCAfvhmF/YISSUt 2TzJpKQg71+ulBXEJCdoiVZx7NkB1LZQ62Jc0OGnVtYV0Dz1PK vAzCLjIZOY1xpnKNefthQ== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] hide `Try 'help' for usage' if help doestn't exist in rescue mode X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2009 15:00:29 -0000 Am Dienstag, den 08.09.2009, 16:49 +0200 schrieb Robert Millan: > On Sun, Sep 06, 2009 at 08:03:31PM +0200, Felix Zielcke wrote: > > I think we shouldn't tell users to type `help' if the command doestn't > > exist in rescue mode, i.e. minicmd isn't included in core.img > > This increases the size of kernel.img for me by 28 bytes. I think it's > > worth. > > > > It's so small I don't bother to attach it: > > > > 2009-09-06 Felix Zielcke > > > > * kern/rescue_parser.c (grub_rescue_parse_line): Only suggest to try > > `help' if the command exists. > > > > diff --git a/kern/rescue_parser.c b/kern/rescue_parser.c > > index 79f32b8..1e0841e 100644 > > --- a/kern/rescue_parser.c > > +++ b/kern/rescue_parser.c > > @@ -61,7 +61,8 @@ grub_rescue_parse_line (char *line, grub_reader_getline_t getline) > > else > > { > > grub_printf ("Unknown command `%s'\n", name); > > - grub_printf ("Try `help' for usage\n"); > > + if (grub_command_find ("help")) > > + grub_printf ("Try `help' for usage\n"); > > } > > > > quit: > > Seems fine. > Ok thanks. Commited. -- Felix Zielcke Proud Debian Maintainer