All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: SephirXV <sephirxv@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/3] bluetooth: hidp+hidraw disconnect
Date: Thu, 10 Sep 2009 19:44:11 +0200	[thread overview]
Message-ID: <1252604651.8931.40.camel@violet> (raw)
In-Reply-To: <21b895620909101040r6887d4c3w511ff975c0e6aca@mail.gmail.com>

Hi Christopher,

> Somewhere between 2.6.26 and 2.6.28, hidraw began connecting to HIDP
> devices which don't strictly define their behavior in the HID usage
> table, and without any patching on my part. These non-compliant
> devices wouldn't automatically disconnect, leaving hidraw files which
> did nothing.
> 
> Signed-off-by: Christopher Olson <sephirxv@gmail.com>
> 
> ---
> 
> --- net/bluetooth/hidp/core.c   2009-09-10 09:32:20.000000000 -0500
> +++ net/bluetooth/hidp/core.c.1 2009-09-10 09:31:37.000000000 -0500
> @@ -40,6 +40,7 @@
> 
>  #include <linux/input.h>
>  #include <linux/hid.h>
> +#include <linux/hidraw.h>
> 
>  #include <net/bluetooth/bluetooth.h>
>  #include <net/bluetooth/hci_core.h>
> @@ -736,6 +737,8 @@ static void hidp_stop(struct hid_device
> 
>         if (hid->claimed & HID_CLAIMED_INPUT)
>                 hidinput_disconnect(hid);
> +       if (hid->claimed & HID_CLAIMED_HIDRAW)
> +               hidraw_disconnect(hid);
>         hid->claimed = 0;
>  }

I am pretty sure such a patch or similar is in net-next-2.6 already.

Regards

Marcel



      reply	other threads:[~2009-09-10 17:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10 17:40 [PATCH 1/3] bluetooth: hidp+hidraw disconnect SephirXV
2009-09-10 17:44 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252604651.8931.40.camel@violet \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=sephirxv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.