From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MmhPu-00035A-PZ for mharc-grub-devel@gnu.org; Sun, 13 Sep 2009 01:14:26 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MmhPs-00032z-2B for grub-devel@gnu.org; Sun, 13 Sep 2009 01:14:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MmhPn-0002yv-6S for grub-devel@gnu.org; Sun, 13 Sep 2009 01:14:23 -0400 Received: from [199.232.76.173] (port=49682 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmhPm-0002yV-Sk for grub-devel@gnu.org; Sun, 13 Sep 2009 01:14:18 -0400 Received: from c60.cesmail.net ([216.154.195.49]:23930) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1MmhPm-0008U9-8Y for grub-devel@gnu.org; Sun, 13 Sep 2009 01:14:18 -0400 Received: from unknown (HELO smtprelay1.cesmail.net) ([192.168.1.111]) by c60.cesmail.net with ESMTP; 13 Sep 2009 01:14:16 -0400 Received: from [192.168.1.220] (c-69-141-194-35.hsd1.pa.comcast.net [69.141.194.35]) by smtprelay1.cesmail.net (Postfix) with ESMTPSA id 079F034C69 for ; Sun, 13 Sep 2009 01:14:12 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <2e59e6970909120754n49b7ba6pa4a484fe6b8da782@mail.gmail.com> References: <20090902110141.GR13423@riva.ucam.org> <20090903143323.GH6656@thorin> <20090903145243.GZ13423@riva.ucam.org> <20090903150859.GA18316@thorin> <1252705386.2616.3.camel@mj> <2e59e6970909120754n49b7ba6pa4a484fe6b8da782@mail.gmail.com> Content-Type: text/plain Date: Sun, 13 Sep 2009 01:14:06 -0400 Message-Id: <1252818846.21312.3.camel@ct> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] save_env variable_name=value X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Sep 2009 05:14:24 -0000 On Sat, 2009-09-12 at 09:54 -0500, richardvoigt@gmail.com wrote: > On Fri, Sep 11, 2009 at 4:43 PM, Pavel Roskin wrote: > > I don't see how grub-mkconfig could compensate for a missing feature in > > save_env. Perhaps I'm missing the context here. > > AFAICT, it's grub.cfg that has to work around using two commands instead of one. Yes, if we want to keep backward compatibility with older modules. > Therefore grub-mkconfig has to generate a longer grub.cfg (not sure > how this makes grub-mkconfig uglier), but that's an incomplete > assessment. There's also a different burden placed on user-edited > configs and usage of the grub console, correct? Correct. > I don't think that the suggestion was meant to save a few bytes in > grub-mkconfig. I think it was suggesting a nicer interface for users > working in the console. Yes. Also, grub-mkconfig could use it once we decide to break backward compatibility with the last version that didn't support save_env with a name. -- Regards, Pavel Roskin