All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Nick Piggin <npiggin@suse.de>
Cc: chris.mason@oracle.com, david@fromorbit.com,
	Andrew Morton <akpm@linux-foundation.org>,
	"Bityutskiy Artem (Nokia-M/Helsinki)"
	<Artem.Bityutskiy@nokia.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] mm: write_cache_pages be more sequential
Date: Mon, 14 Sep 2009 18:44:47 +0300	[thread overview]
Message-ID: <1252943087.3778.0.camel@localhost> (raw)
In-Reply-To: <4AA513AA.3010206@nokia.com>

On Mon, 2009-09-07 at 17:07 +0300, Adrian Hunter wrote:
> From 6f3bb7c26936c45d810048f59c369e8d5a5623fc Mon Sep 17 00:00:00 2001
> From: Adrian Hunter <adrian.hunter@nokia.com>
> Date: Mon, 7 Sep 2009 10:49:11 +0300
> Subject: [PATCH] mm: write_cache_pages be more sequential
> 
> If a file is written to sequentially, then writeback
> should write the pages sequentially also.  However,
> that does not always happen.  For example:
> 
> 1) user writes pages 0, 1 and 2 but 2 is incomplete
> 2) write_cache_pages writes pages 0, 1 and 2 and sets
> writeback_index to 3
> 3) user finishes writing page 2 and writes pages 3 and 4
> 4) write_cache_pages writes pages 3 and 4, and then cycles
> back and writes page 2 again.
> 
> So the pages are written out in the order 0, 1, 2, 3 ,4 ,2
> instead of 0, 1, 2, 2, 3, 4.
> 
> This situation was noticed on UBIFS because it writes
> directly from writepage.  Hence if there is an unexpected
> power-loss, a file will end up with a hole even though
> the file was written sequentially by the user.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com>

I wonder, who would merge this patch?

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)


      parent reply	other threads:[~2009-09-14 15:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-07 14:07 [RFC][PATCH] mm: write_cache_pages be more sequential Adrian Hunter
2009-09-07 14:15 ` Nick Piggin
2009-09-07 14:29   ` Adrian Hunter
2009-09-07 14:45     ` Nick Piggin
2009-09-07 18:12       ` Aaron Straus
2009-09-09  8:03       ` Adrian Hunter
2009-09-14 15:44 ` Artem Bityutskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252943087.3778.0.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=david@fromorbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.