All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: James Morris <jmorris@namei.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	Debora Velarde <debora@linux.vnet.ibm.com>,
	Marcel Selhorst <m.selhorst@sirrix.com>,
	Jan Beulich <jbeulich@novell.com>
Subject: Re: [PATCH] TPM: Fixup pcrs sysfs file
Date: Mon, 14 Sep 2009 14:45:28 -0300	[thread overview]
Message-ID: <1252950328.9372.154.camel@blackbox> (raw)
In-Reply-To: <20090914062520.GB23467@obsidianresearch.com>

On Mon, 2009-09-14 at 00:25 -0600, Jason Gunthorpe wrote:
> On Mon, Sep 14, 2009 at 12:36:39PM +1000, James Morris wrote:
> > On Thu, 3 Sep 2009, Jason Gunthorpe wrote:
> 
> > > > That sounds like a fairly serious bug, and this looks like a 2.6.31
> > > > patch.
> > 
> > Any comments from the maintainers on this patch?
> 

Sorry for the delay, just reviewed the patches and Jason is right,
Jason's and Andrew's final work (last patch) is great.

> FWIW, I didn't mention in the patch emails, but all the patches I sent
> fix regressions that have been introduced in the past couple years by
> clean up patches that never tested the code paths they alter.
> 

Hold on, I tested these functions before when submitting them and they
worked fine, and, I couldn't figure it out why yet (only guesses), they
still work for me here, probably due the mishandling of the be32
formatted value when calling transmit_cmd().


Thanks,
Rajiv


  parent reply	other threads:[~2009-09-14 17:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-02  3:16 [PATCH] TPM: Fixup pcrs sysfs file Jason Gunthorpe
2009-09-03 23:52 ` Andrew Morton
2009-09-04  1:28   ` Jason Gunthorpe
2009-09-14  2:36     ` James Morris
2009-09-14  6:25       ` Jason Gunthorpe
2009-09-14  7:11         ` Andrew Morton
2009-09-14 17:45         ` Rajiv Andrade [this message]
2009-09-14 17:52           ` Rajiv Andrade
2009-09-14 18:00           ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252950328.9372.154.camel@blackbox \
    --to=srajiv@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=debora@linux.vnet.ibm.com \
    --cc=jbeulich@novell.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.selhorst@sirrix.com \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.