From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
To: linux-input@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [PATCH] input: make gpio-keys use IRQF_SHARED
Date: Wed, 16 Sep 2009 19:03:18 +0400 [thread overview]
Message-ID: <1253113398-22751-1-git-send-email-dbaryshkov@gmail.com> (raw)
There is nothing that disallows gpio-keys to share it's IRQ line
w/ other drivers. Make it use IRQF_SHARED in request_irq().
An example of other driver with which I'd like to share IRQ line
for GPIO buttons is ledtrig-gpio.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
drivers/input/keyboard/gpio_keys.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index efed0c9..9fc2fab 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -147,6 +147,7 @@ static int __devinit gpio_keys_probe(struct platform_device *pdev)
}
error = request_irq(irq, gpio_keys_isr,
+ IRQF_SHARED |
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
button->desc ? button->desc : "gpio_keys",
bdata);
--
1.6.3.3
next reply other threads:[~2009-09-16 15:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 15:03 Dmitry Eremin-Solenikov [this message]
2009-09-16 16:28 ` [PATCH] input: make gpio-keys use IRQF_SHARED Dmitry Torokhov
2009-09-16 18:41 ` Dmitry Eremin-Solenikov
2009-09-18 11:44 ` Dmitry Eremin-Solenikov
2009-09-22 16:42 ` Dmitry Torokhov
2009-09-22 18:50 ` Ferenc Wagner
2009-09-22 15:14 ` Ferenc Wagner
2009-09-22 16:41 ` Dmitry Torokhov
2009-09-22 19:06 ` Ferenc Wagner
2009-09-28 17:03 ` Dmitry Torokhov
2009-10-01 14:02 ` Ferenc Wagner
2009-10-12 17:09 ` Ferenc Wagner
2009-10-14 8:04 ` Dmitry Torokhov
2009-10-14 11:03 ` gpio_get_value in atomic context (was: make gpio-keys use IRQF_SHARED) Ferenc Wagner
2009-10-14 11:40 ` Arve Hjønnevåg
2009-11-28 1:08 ` David Brownell
2009-11-30 15:35 ` gpio_get_value in atomic context Ferenc Wagner
2009-12-09 13:33 ` Ferenc Wagner
2009-10-14 11:25 ` [PATCH] input: make gpio-keys use IRQF_SHARED Ferenc Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253113398-22751-1-git-send-email-dbaryshkov@gmail.com \
--to=dbaryshkov@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.