From: Daniel Walker <dwalker@fifo99.com>
To: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>
Cc: linux-kernel@vger.kernel.org, Greg Ungerer <gerg@uclinux.org>,
uclinux-dev@uclinux.org
Subject: Re: [PATCH] Add uboot commandline argument passing support to m68knommu (Try #2)
Date: Fri, 18 Sep 2009 10:54:01 -0700 [thread overview]
Message-ID: <1253296441.7060.49.camel@desktop> (raw)
In-Reply-To: <20090918174936.GJ23702@csclub.uwaterloo.ca>
On Fri, 2009-09-18 at 13:49 -0400, Lennart Sorensen wrote:
> On Fri, Sep 18, 2009 at 09:39:04AM -0700, Daniel Walker wrote:
> > You have a couple of various checkpatch errors in this patch. We use
> > scripts/checkpatch.pl to check for code style issues. Could you run that
> > on your patch and fix any errors it finds? A couple are whitespace
> > related and you can use scripts/cleanpatch or scripts/cleanfile to
> > remove whitespace (so I hear. I've never run those scripts personally)
>
> Oh dear. I guess the original patch was a bit messy then. OK here we
> go again with a checkpatch approved patch.
Much better, thanks for doing that..
Daniel
next prev parent reply other threads:[~2009-09-18 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 16:27 [PATCH] Add uboot commandline argument passing support to m68knommu Lennart Sorensen
2009-09-18 16:39 ` Daniel Walker
2009-09-18 17:49 ` [PATCH] Add uboot commandline argument passing support to m68knommu (Try #2) Lennart Sorensen
2009-09-18 17:54 ` Daniel Walker [this message]
2009-10-01 6:28 ` [uClinux-dev] " Greg Ungerer
2009-10-02 14:32 ` Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253296441.7060.49.camel@desktop \
--to=dwalker@fifo99.com \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.