From: Daniel Walker <dwalker@fifo99.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg KH <greg@kroah.com>, Douglas Gilbert <dgilbert@interlog.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Hannes Reinecke <hare@suse.de>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Mike Christie <michaelc@cs.wisc.edu>,
Joel Becker <joel.becker@oracle.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Boaz Harrosh <bharrosh@panasas.com>,
Florian Haas <florian.haas@linbit.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>
Subject: Re: [RFC v2 PATCH 0/19] A kernel-level configfs enabled generic target engine for Linux v2.6.32
Date: Fri, 18 Sep 2009 18:15:25 -0700 [thread overview]
Message-ID: <1253322925.6699.8.camel@desktop> (raw)
In-Reply-To: <1253311656.4498.143.camel@haakon2.linux-iscsi.org>
On Fri, 2009-09-18 at 15:07 -0700, Nicholas A. Bellinger wrote:
> Greetings all,
>
> This is the second round of request for comments for TCM/ConfigFS v3.2
> from lio-core-2.6.git.
> Thanks to the folks who made comments, and I again invite people to
> take a look and make
> recommendations on how the code can be futher improved to use the best
> available upstream
> interfaces.
There are still a couple of minor checkpatch errors in the series, but
it's nothing you would need to resubmit because of ..
In patch 2 the following are fixable,
ERROR: return is not a function, parentheses are not required
#3401: FILE: include/target/configfs_macros.h:104:
+ return((ci) ? container_of(to_config_group(ci), struct _item, \
ERROR: trailing whitespace
#3438: FILE: include/target/configfs_macros.h:141:
+CONFIGFS_EATTR_OPS_STORE(_name, _item);^I$
and in Patch 18, and 19 there are a couple more whitespace related
errors you could fix..
Daniel
next prev parent reply other threads:[~2009-09-19 1:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 22:07 [RFC v2 PATCH 0/19] A kernel-level configfs enabled generic target engine for Linux v2.6.32 Nicholas A. Bellinger
2009-09-19 1:15 ` Daniel Walker [this message]
2009-09-19 2:07 ` Nicholas A. Bellinger
2009-09-21 12:04 ` Vladislav Bolkhovitin
2009-09-21 15:38 ` Nicholas A. Bellinger
2009-09-21 18:52 ` Vladislav Bolkhovitin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253322925.6699.8.camel@desktop \
--to=dwalker@fifo99.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=bharrosh@panasas.com \
--cc=dgilbert@interlog.com \
--cc=florian.haas@linbit.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=greg@kroah.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=joel.becker@oracle.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
--cc=philipp.reisner@linbit.com \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.