From: Daniel Walker <dwalker@fifo99.com>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: tglx@linutronix.de, hpa@zytor.com, mingo@elte.hu,
yinghai@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] x86, apic: use logical flat on intel with <= 8 logical cpus
Date: Fri, 18 Sep 2009 19:19:50 -0700 [thread overview]
Message-ID: <1253326790.6699.38.camel@desktop> (raw)
In-Reply-To: <1253325936.3948.720.camel@sbs-t61.sc.intel.com>
On Fri, 2009-09-18 at 19:05 -0700, Suresh Siddha wrote:
> + switch (boot_cpu_data.x86_vendor) {
> + case X86_VENDOR_INTEL:
> + if (num_processors > 8)
> + apic = &apic_physflat;
> + break;
> + case X86_VENDOR_AMD:
> + if (max_physical_apicid >= 8)
> + apic = &apic_physflat;
> + }
There are a couple of checkpatch issues in this patch .. Could you run
it through and fix the errors that show up.. One is that you need 1 less
tab for the code inside the switch statement .. You have another switch
statement in apic.c that needs similar attention .
Daniel
next prev parent reply other threads:[~2009-09-19 2:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-19 2:05 [patch] x86, apic: use logical flat on intel with <= 8 logical cpus Suresh Siddha
2009-09-19 2:19 ` Daniel Walker [this message]
2009-09-19 2:29 ` Suresh Siddha
2009-09-19 3:11 ` Daniel Walker
2009-09-19 7:59 ` [tip:x86/urgent] x86, apic: Use " tip-bot for Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253326790.6699.38.camel@desktop \
--to=dwalker@fifo99.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.