All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Miell <nmiell@comcast.net>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	viro@zeniv.linux.org.uk, hch@infradead.org
Subject: Re: [PATCH] VFS: document what MAY_ACCESS means
Date: Sun, 20 Sep 2009 18:52:01 -0700	[thread overview]
Message-ID: <1253497921.30237.1.camel@entropy> (raw)
In-Reply-To: <20090921012933.2631.85495.stgit@paris.rdu.redhat.com>

Since this is a documentation patch, here are some nits.

> +/*
> + * The vfs MAY_ACCESS flag really means that we might not use the object
> + * immediately (consider chdir which might not actually use the new dir).
> + * Thus permissions must be checked mmediately rather than relying on later
                                       ^ immediately
> + * checks during the actual user of the object in question.  This is an
                               ^ use
> + * internal flag and should not come from userspace.
> + */
>  #define MAY_ACCESS 16
>  #define MAY_OPEN 32

-- 
Nicholas Miell <nmiell@comcast.net>


  reply	other threads:[~2009-09-21  1:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-21  1:29 [PATCH] VFS: document what MAY_ACCESS means Eric Paris
2009-09-21  1:52 ` Nicholas Miell [this message]
2009-09-21  8:10 ` Jamie Lokier
2009-09-21 12:29   ` Trond Myklebust
2009-09-21 18:53     ` Jamie Lokier
2009-09-21 20:18       ` Trond Myklebust
2009-09-21 21:39         ` fchdir, EACCESS and when to check (was: [PATCH] VFS: document what MAY_ACCESS means) Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253497921.30237.1.camel@entropy \
    --to=nmiell@comcast.net \
    --cc=eparis@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.