From: Daniel Walker <dwalker@fifo99.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Greg KH <greg@kroah.com>,
kernel list <linux-kernel@vger.kernel.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
arve@android.com, swetland@google.com
Subject: Re: Staging: dream: fix build errorsg
Date: Sat, 26 Sep 2009 11:48:01 -0700 [thread overview]
Message-ID: <1253990881.20648.427.camel@desktop> (raw)
In-Reply-To: <20090926114408.GC3105@ucw.cz>
On Sat, 2009-09-26 at 13:44 +0200, Pavel Machek wrote:
> On Wed 2009-09-16 10:48:03, Greg KH wrote:
> > On Fri, Sep 11, 2009 at 11:27:52PM +0200, Pavel Machek wrote:
> > >
> > > Fix compilation of gpio_* input drivers on -next kernel. Adds needed
> > > headers and removes unprotected wakelock/earlysuspend dependencies.
> > >
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> > >
> > > ---
> > > drivers/staging/dream/gpio_event.c | 3
> > > drivers/staging/dream/gpio_input.c | 7 -
> > > drivers/staging/dream/gpio_matrix.c | 8 -
> > > include/linux/gpio_event.h | 154 ++++++++++++++++++++++++++++++++++++
> >
> > This adds a file outside of the staging tree, so I'm going to drop it,
> > sorry.
>
> Ok, whats the preffered solution here? Create staging/include/linux
> and add gcc -I magic so it gets used?
Could we do drivers/staging/include/ then make a link from
include/staging/ (or something) into the drivers/staging include
directory at build time?
The lower level msm sub-architecture already links to includes directly
into the staging directory like this,
#include <../../../drivers/staging/android/timed_gpio.h>
which looks pretty ugly ..
Daniel
prev parent reply other threads:[~2009-09-26 18:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 9:22 newer version of HTC Dream support Pavel Machek
2009-09-01 13:21 ` Pavel Machek
2009-09-04 16:03 ` Randy Dunlap
2009-09-11 7:16 ` Pavel Machek
2009-09-11 14:58 ` Randy Dunlap
2009-09-11 16:13 ` Pavel Machek
2009-09-11 16:21 ` Randy Dunlap
2009-09-11 21:27 ` [patch] " Pavel Machek
2009-09-11 22:34 ` Randy Dunlap
2009-09-13 8:37 ` Pavel Machek
2009-09-13 20:54 ` Randy Dunlap
2009-09-13 22:11 ` Pavel Machek
2009-09-13 22:25 ` Pavel Machek
2009-09-13 22:38 ` Pavel Machek
2009-09-13 23:21 ` Randy Dunlap
2009-09-14 7:06 ` Pavel Machek
2009-09-14 7:11 ` Pavel Machek
2009-09-14 19:56 ` Randy Dunlap
2009-09-14 21:24 ` Greg KH
2009-09-14 21:46 ` Pavel Machek
2009-09-14 21:51 ` Greg KH
2009-09-14 21:54 ` Pavel Machek
2009-09-14 22:04 ` Greg KH
2009-09-14 22:21 ` Pavel Machek
2009-09-14 22:02 ` Pavel Machek
[not found] ` <20090916174803.GA28689@kroah.com>
2009-09-26 11:44 ` Staging: dream: fix build errorsg Pavel Machek
2009-09-26 18:48 ` Daniel Walker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253990881.20648.427.camel@desktop \
--to=dwalker@fifo99.com \
--cc=arve@android.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=randy.dunlap@oracle.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.