From: Artem Bityutskiy <dedekind1@gmail.com>
To: Corentin Chary <corentincj@iksaif.net>
Cc: linux-mtd@lists.infradead.org, Adrian Hunter <adrian.hunter@nokia.com>
Subject: Re: [PATCH 1/2] UBI: Add ubi_open_volume_path()
Date: Tue, 29 Sep 2009 17:27:37 +0300 [thread overview]
Message-ID: <1254234457.3778.84.camel@localhost> (raw)
In-Reply-To: <1254165012-10798-1-git-send-email-corentincj@iksaif.net>
On Mon, 2009-09-28 at 21:10 +0200, Corentin Chary wrote:
> Add an ubi_open_volume_path(path, mode) function which works like
> open_bdev_exclusive(path, mode, ...) where path is the special file
> representing the UBI volume, typically /dev/ubi0_0.
>
> Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Looks good, and actually works. And I like that I can now do:
mount -t ubifs /dev/ubi_whatever_name /mnt/ubifs
And when your user-space changes hit distros, I will not have to
even specify -t ubifs.
I'm not entirely sure vs the 'kern_path()' usage though. Could you
please post your patch to these lists as well:
linux-fsdevel@vger.kernel.org
linux-kernel@vger.kernel.org
I'll push your patches to the ubi-2.6.git now, but I would not want to
make these changes sneak into mainline without being sent to lkml, just
because I'm not entirely sure about the 'kern_path()'. But for me this
looks ok.
Thanks!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2009-09-29 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 19:10 [PATCH 1/2] UBI: Add ubi_open_volume_path() Corentin Chary
2009-09-28 19:10 ` [PATCH 2/2] UBIFS: Use ubi_open_volume_path() in open_ubi() Corentin Chary
2009-09-29 14:27 ` Artem Bityutskiy [this message]
2009-09-29 17:29 ` [PATCH 1/2] UBI: Add ubi_open_volume_path() Corentin Chary
2009-09-29 17:29 ` [PATCH 2/2] UBIFS: Use ubi_open_volume_path() in open_ubi() Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254234457.3778.84.camel@localhost \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@nokia.com \
--cc=corentincj@iksaif.net \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.