From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Will Cohen <wwcohen@gmail.com>,
Keno Fischer <keno@juliacomputing.com>,
Michael Roitzsch <reactorcontrol@icloud.com>,
hi@alyssa.is, Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH v2 04/11] 9p: darwin: Handle struct dirent differences
Date: Fri, 28 Jan 2022 16:48:00 +0100 [thread overview]
Message-ID: <12546246.2XztgVCrSq@silver> (raw)
In-Reply-To: <CAB26zV0T+mwNCDt9fYKy5hkV=8dnA=CFcu8K5X6Lo+WhFtEO2Q@mail.gmail.com>
On Donnerstag, 27. Januar 2022 22:48:02 CET Will Cohen wrote:
> If acceptable, we'd still propose leaving these changes as is for
> expediency's sake, rather than using our dirent and then translating it all
> to save one read from the FS layer.
The problem is V9fsFidState *fidp is a shared resource that might become
mutated by other threads in between and could therefore lead to concurrency
issues and undefined behaviour, whereas struct dirent is a local resource not
being shared.
See also BTW:
https://lore.kernel.org/qemu-devel/20220127212734.218900-1-vt@altlinux.org/
Best regards,
Christian Schoenebeck
next prev parent reply other threads:[~2022-01-28 16:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 0:49 [PATCH v2 00/11] 9p: Add support for darwin Will Cohen
2021-11-22 0:49 ` [PATCH v2 01/11] 9p: linux: Fix a couple Linux assumptions Will Cohen
2021-11-24 12:41 ` Christian Schoenebeck
2021-11-22 0:49 ` [PATCH v2 02/11] 9p: Rename 9p-util -> 9p-util-linux Will Cohen
2021-11-22 0:49 ` [PATCH v2 03/11] 9p: darwin: Handle struct stat(fs) differences Will Cohen
2021-11-24 14:23 ` Christian Schoenebeck
2021-12-01 22:46 ` Will Cohen
2021-12-02 15:35 ` Christian Schoenebeck
2021-11-22 0:49 ` [PATCH v2 04/11] 9p: darwin: Handle struct dirent differences Will Cohen
2021-11-24 14:58 ` Christian Schoenebeck
2021-11-24 15:45 ` Michael Roitzsch
2021-11-24 19:09 ` Christian Schoenebeck
2022-01-27 21:48 ` Will Cohen
2022-01-28 15:48 ` Christian Schoenebeck [this message]
2021-11-22 0:49 ` [PATCH v2 05/11] 9p: darwin: Ignore O_{NOATIME, DIRECT} Will Cohen
2021-11-22 0:49 ` [PATCH v2 06/11] 9p: darwin: Compatibility defn for XATTR_SIZE_MAX Will Cohen
2021-11-24 15:44 ` Christian Schoenebeck
2021-11-22 0:49 ` [PATCH v2 07/11] 9p: darwin: *xattr_nofollow implementations Will Cohen
2021-11-22 0:49 ` [PATCH v2 08/11] 9p: darwin: Compatibility for f/l*xattr Will Cohen
2021-11-24 16:20 ` Christian Schoenebeck
2022-01-27 21:47 ` Will Cohen
2021-11-22 0:49 ` [PATCH v2 09/11] 9p: darwin: Provide fallback impl for utimensat Will Cohen
2021-11-24 17:07 ` Christian Schoenebeck
2021-11-22 0:49 ` [PATCH v2 10/11] 9p: darwin: Implement compatibility for mknodat Will Cohen
2021-11-24 17:20 ` Christian Schoenebeck
2022-01-27 21:47 ` Will Cohen
2022-01-28 15:15 ` Christian Schoenebeck
2022-01-28 18:28 ` Will Cohen
2022-01-31 22:26 ` Will Cohen
2022-02-01 12:44 ` Christian Schoenebeck
2021-11-22 0:49 ` [PATCH v2 11/11] 9p: darwin: meson: Allow VirtFS on Darwin Will Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12546246.2XztgVCrSq@silver \
--to=qemu_oss@crudebyte.com \
--cc=groug@kaod.org \
--cc=hi@alyssa.is \
--cc=keno@juliacomputing.com \
--cc=qemu-devel@nongnu.org \
--cc=reactorcontrol@icloud.com \
--cc=wwcohen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.