From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: Scott Wood <scottwood@freescale.com>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
Rex Feany <RFeany@mrv.com>
Subject: Re: [PATCH] powerpc/8xx: fix regression introduced by cache coherency rewrite
Date: Mon, 05 Oct 2009 07:28:38 +1100 [thread overview]
Message-ID: <1254688118.7122.30.camel@pasglop> (raw)
In-Reply-To: <OF7C895670.A7F16A1A-ONC1257645.00620A4D-C1257645.006ED40F@transmode.se>
> I have managed to update the TLB code to make proper use of dirty and accessed states.
> Advantages are:
> - I/D TLB Miss never needs to write to the linux pte, saving a few cycles
That's good, that leaves us with only 40x to fix now. Also we can remove
atomic updates of PTEs for all non-hash. It's pointless on those CPUs
anyway.
> - Accessed is only set by I/D TLB Error, should be a plus when SWAP is used.
No need for that neither.
ISI/DSI shouldn't touch the PTE. They should just fall back to C code
which takes care of it all.l
> - _PAGE_DIRTY is mapped to 0x100, the changed bit, and is set directly
> and there will be no extra DTLB Error to actually set the changed bit
> when a page has been made dirty.
> - Proper RO/RW mapping of user space.
>
> Cons:
> - 4 more insn in TLB Miss handlers, but the since the linux pte isn't
> written it should still be a win.
>
> However, I did this on my 2.4 tree but I can port it to 2.6 if you guys
> can test it for me.
Why don't you use and test 2.6 ? :-)
Cheers,
Ben.
next prev parent reply other threads:[~2009-10-04 20:28 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 0:45 [PATCH] powerpc/8xx: fix regression introduced by cache coherency rewrite Rex Feany
2009-09-24 6:44 ` Benjamin Herrenschmidt
2009-09-24 23:33 ` Rex Feany
2009-09-24 23:52 ` Benjamin Herrenschmidt
2009-09-25 1:35 ` Rex Feany
2009-09-25 1:51 ` Benjamin Herrenschmidt
2009-09-25 3:03 ` Benjamin Herrenschmidt
2009-09-25 8:31 ` Joakim Tjernlund
2009-09-25 9:47 ` Benjamin Herrenschmidt
2009-09-25 10:21 ` Joakim Tjernlund
2009-09-25 21:18 ` Rex Feany
2009-09-27 13:22 ` Joakim Tjernlund
2009-09-28 3:21 ` Benjamin Herrenschmidt
2009-09-28 7:22 ` Joakim Tjernlund
2009-09-28 7:34 ` Benjamin Herrenschmidt
2009-09-28 7:39 ` Joakim Tjernlund
2009-09-28 10:02 ` Joakim Tjernlund
2009-09-29 1:21 ` Rex Feany
2009-09-29 6:26 ` Joakim Tjernlund
2009-09-29 7:07 ` Benjamin Herrenschmidt
2009-09-29 8:13 ` Joakim Tjernlund
2009-09-29 8:16 ` Benjamin Herrenschmidt
2009-09-29 8:24 ` Joakim Tjernlund
2009-09-29 11:56 ` Joakim Tjernlund
2009-09-29 21:03 ` Rex Feany
2009-09-30 7:59 ` Joakim Tjernlund
2009-09-30 8:19 ` Joakim Tjernlund
2009-09-30 9:00 ` Rex Feany
2009-09-30 9:58 ` Joakim Tjernlund
2009-09-30 11:18 ` Joakim Tjernlund
2009-09-30 17:23 ` Joakim Tjernlund
2009-09-30 22:35 ` Benjamin Herrenschmidt
2009-10-01 7:05 ` Joakim Tjernlund
2009-10-02 13:06 ` Joakim Tjernlund
2009-10-02 18:10 ` Joakim Tjernlund
2009-10-02 21:49 ` Scott Wood
2009-10-02 22:04 ` Benjamin Herrenschmidt
2009-10-05 19:28 ` Scott Wood
2009-10-05 20:29 ` Benjamin Herrenschmidt
2009-10-05 21:04 ` Scott Wood
2009-10-03 8:05 ` Joakim Tjernlund
2009-10-03 8:31 ` Benjamin Herrenschmidt
2009-10-03 9:24 ` Joakim Tjernlund
2009-10-03 10:57 ` Benjamin Herrenschmidt
2009-10-03 11:47 ` Joakim Tjernlund
2009-10-04 8:35 ` Joakim Tjernlund
2009-10-04 20:26 ` Benjamin Herrenschmidt
2009-10-04 20:38 ` Joakim Tjernlund
2009-10-05 18:24 ` Scott Wood
2009-10-05 18:50 ` Joakim Tjernlund
2009-10-04 20:10 ` Joakim Tjernlund
2009-10-04 20:28 ` Benjamin Herrenschmidt [this message]
2009-10-04 20:45 ` Joakim Tjernlund
2009-10-05 7:28 ` Joakim Tjernlund
2009-10-05 19:16 ` Joakim Tjernlund
2009-10-05 20:28 ` Benjamin Herrenschmidt
2009-09-29 7:07 ` Benjamin Herrenschmidt
2009-09-29 21:09 ` Rex Feany
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254688118.7122.30.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=RFeany@mrv.com \
--cc=joakim.tjernlund@transmode.se \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.