Re: [PATCH] [OneNAND] Standardising prints in onenand_base.c

[Artem Bityutskiy <dedekind1@gmail.com>]

On Mon, 2009-10-05 at 10:04 +0300, Artem Bityutskiy wrote:
> On Thu, 2009-10-01 at 13:08 +0530, Amul Kumar Saha wrote:
> > Note: Reposting with corrected Signed-Off
> > 
> > This patch resolves all the prints present in onenand_base.c
> > Primarily, it replaces the hard-coded function names in the prints,
> > and makes use of __func__.
> > 
> > Signed-off-by: Amul Kumar Saha <amul.saha@samsung.com>
> > ---
> >  onenand_base.c |  172 +++++++++++++++++++++++++++++++++++----------------------
> >  1 file changed, 106 insertions(+), 66 deletions(-)
> 
> David decided to ignore the discussion and pushed your first patch
> instead of this one already.

Oh, David actually took the right patch, sorry. You decided to re-send
the old patch and did not address the nitpicks I pointed, e.g., there is
still:

DEBUG(MTD_DEBUG_LEVEL3, "onenand_erase: start = 0x%012llx, len = %llu
\n", (unsigned long long) instr->addr, (unsigned long long) instr->len);

Well, not big deal, but would be nice to have a follow up patch.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)