From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sachin Sant <sachinp@in.ibm.com>
Cc: linuxppc-dev@ozlabs.org, rostedt@goodmis.org
Subject: Re: [FTRACE] Enabling function_graph causes OOPS
Date: Wed, 07 Oct 2009 20:10:21 +1100 [thread overview]
Message-ID: <1254906621.2409.1.camel@pasglop> (raw)
In-Reply-To: <4ACC57C4.5010002@in.ibm.com>
On Wed, 2009-10-07 at 14:26 +0530, Sachin Sant wrote:
> As Ben suggested, i changed LOAD_REG_IMMEDIATE() to LOAD_REG_ADDR()
> as follows.
>
> - LOAD_REG_IMMEDIATE(r4,ftrace_return_to_handler)
> + LOAD_REG_ADDR(r4,ftrace_return_to_handler)
>
> With this change compile time warnings about bad relocations
> related to ftrace are gone.
You also need to make sure r2 is properly loaded with the kernel TOC
pointer, something like ld r2,PACAKTOC(r13) before the LOAD_REG_ADDR.
Cheers,
Ben.
next prev parent reply other threads:[~2009-10-07 9:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 10:26 [FTRACE] Enabling function_graph causes OOPS Sachin Sant
2009-07-14 22:45 ` Steven Rostedt
2009-08-03 10:40 ` Sachin Sant
2009-09-09 1:05 ` Steven Rostedt
2009-09-09 6:27 ` Sachin Sant
2009-09-09 19:42 ` Steven Rostedt
2009-09-10 5:32 ` Sachin Sant
2009-09-11 3:05 ` Steven Rostedt
2009-09-11 4:26 ` Sachin Sant
2009-09-11 18:05 ` Steven Rostedt
2009-09-13 4:07 ` Steven Rostedt
2009-09-13 4:37 ` Benjamin Herrenschmidt
2009-09-13 13:21 ` Steven Rostedt
2009-09-13 20:25 ` Benjamin Herrenschmidt
2009-09-14 8:00 ` Benjamin Herrenschmidt
2009-10-05 13:25 ` Steven Rostedt
2009-10-05 20:20 ` Benjamin Herrenschmidt
2009-10-05 20:37 ` Steven Rostedt
2009-10-07 8:56 ` Sachin Sant
2009-10-07 9:10 ` Benjamin Herrenschmidt [this message]
2009-10-08 14:51 ` [PATCH] Ftrace : fix function_graph tracer OOPS Sachin Sant
2009-10-14 3:01 ` Steven Rostedt
2009-10-14 6:13 ` Sachin Sant
2009-10-14 6:15 ` Benjamin Herrenschmidt
2009-10-14 12:12 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254906621.2409.1.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rostedt@goodmis.org \
--cc=sachinp@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.