From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH qemu-kvm] Enable UFO on virtio-net and tap devices
Date: Thu, 08 Oct 2009 11:07:57 +0100
Message-ID: <1254996477.8069.17.camel@blaa>
References: <1254952242.31575.179.camel@w-sridhar.beaverton.ibm.com>
Reply-To: Mark McLoughlin <markmc@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: avi@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org
To: Sridhar Samudrala <sri@us.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58509 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754922AbZJHKKC (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 8 Oct 2009 06:10:02 -0400
In-Reply-To: <1254952242.31575.179.camel@w-sridhar.beaverton.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, 2009-10-07 at 14:50 -0700, Sridhar Samudrala wrote:
> linux 2.6.32 includes UDP fragmentation offload support in software. 
> So we can enable UFO on the host tap device if supported and allow setting
> UFO on virtio-net in the guest.

Hmm, we really need to detect whether the host has tuntap UFO support
before advertising it to the guest. Maybe in net_tap_fd_init() we should
toggle TUN_F_UFO back and forth and check for EINVAL?

Cheers,
Mark.