From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mvpyz-0000qs-39 for mharc-grub-devel@gnu.org; Thu, 08 Oct 2009 06:12:25 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mvpyw-0000q5-3z for grub-devel@gnu.org; Thu, 08 Oct 2009 06:12:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mvpyr-0000oW-Ah for grub-devel@gnu.org; Thu, 08 Oct 2009 06:12:21 -0400 Received: from [199.232.76.173] (port=49155 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mvpyq-0000oN-ND for grub-devel@gnu.org; Thu, 08 Oct 2009 06:12:16 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:63308) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mvpyq-00065t-1Q for grub-devel@gnu.org; Thu, 08 Oct 2009 06:12:16 -0400 Received: from [85.180.2.163] (e180002163.adsl.alicedsl.de [85.180.2.163]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0MbcUz-1McwBM0XmX-00JgDA; Thu, 08 Oct 2009 12:12:13 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20091007211334.GA31055@thorin> References: <20091007211334.GA31055@thorin> Content-Type: text/plain; charset="UTF-8" Date: Thu, 08 Oct 2009 12:12:11 +0200 Message-Id: <1254996731.2857.13.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/sGSrhfoGt1iZEzIRQC3+QloRdKrZeYNGEODr 0Vnw4CntwxW4JrwgUIKGkq/i9d7O8mL9vowRtHgGpk317UqIXt is2xyltp0G4CZi4RBmpzw== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2009 10:12:22 -0000 Am Mittwoch, den 07.10.2009, 23:13 +0200 schrieb Robert Millan: > (grub_cpuid_has_longmode): ... this. Update all users. Remove > `unsigned' attribute. I think that should be `static' not `unsigned': -static unsigned char has_longmode = 0; +unsigned char grub_cpuid_has_longmode = 0; But don't we need to add now an `insmod cpuid' in grub-mkconfig so that this actually works / is useful? Or does the cpuid command get loaded automatically somewhere already? -- Felix Zielcke Proud Debian Maintainer and GNU GRUB developer