From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark McLoughlin Subject: Re: [PATCH qemu-kvm] Enable UFO on virtio-net and tap devices Date: Fri, 09 Oct 2009 08:11:28 +0100 Message-ID: <1255072288.2786.13.camel@blaa> References: <1254952242.31575.179.camel@w-sridhar.beaverton.ibm.com> <1254996477.8069.17.camel@blaa> <1255041101.20627.51.camel@w-sridhar.beaverton.ibm.com> Reply-To: Mark McLoughlin Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: avi@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org To: Sridhar Samudrala Return-path: Received: from mx1.redhat.com ([209.132.183.28]:18283 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933117AbZJIHNt (ORCPT ); Fri, 9 Oct 2009 03:13:49 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n997DN4o001186 for ; Fri, 9 Oct 2009 03:13:23 -0400 In-Reply-To: <1255041101.20627.51.camel@w-sridhar.beaverton.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2009-10-08 at 15:31 -0700, Sridhar Samudrala wrote: > On Thu, 2009-10-08 at 11:07 +0100, Mark McLoughlin wrote: > > On Wed, 2009-10-07 at 14:50 -0700, Sridhar Samudrala wrote: > > > linux 2.6.32 includes UDP fragmentation offload support in software. > > > So we can enable UFO on the host tap device if supported and allow setting > > > UFO on virtio-net in the guest. > > > > Hmm, we really need to detect whether the host has tuntap UFO support > > before advertising it to the guest. Maybe in net_tap_fd_init() we should > > toggle TUN_F_UFO back and forth and check for EINVAL? > > Sure. Here is an updated patch that checks for UFO support in host. Looks good to me, thanks Acked-by: Mark McLoughlin Cheers, Mark.