All of lore.kernel.org
 help / color / mirror / Atom feed
From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>,
	Garrett Cooper <yanegomi@gmail.com>
Cc: LTP list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH 1/1] p9auth: fix a bug in the p9auth setup script
Date: Tue, 13 Oct 2009 20:13:51 +0530	[thread overview]
Message-ID: <1255445031.8438.70.camel@subratamodak.linux.ibm.com> (raw)
In-Reply-To: <20091008165929.GA27576@us.ibm.com>

On Thu, 2009-10-08 at 11:59 -0500, Serge E. Hallyn wrote: 
> If by chance /dev/caphash existed but /dev/capuse did not, then
> the checkp9auth.sh script would use $maj without setting it.
> 
> Signed-off-by: Serge Hallyn <serue@us.ibm.com>

Garrettś recent changes deleted this file:
http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/security/p9auth/checkp9auth.sh?hideattic=0&view=log,

|diff --git a/testcases/kernel/security/p9auth/checkp9auth.sh
b/testcases/kernel/security/p9auth/checkp9auth.sh
|index 4365427..4a5a7d4 100755
|--- a/testcases/kernel/security/p9auth/checkp9auth.sh
|+++ b/testcases/kernel/security/p9auth/checkp9auth.sh
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.
2 out of 2 hunks ignored

Regards--
Subrata

> ---
>  testcases/kernel/security/p9auth/checkp9auth.sh |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/testcases/kernel/security/p9auth/checkp9auth.sh b/testcases/kernel/security/p9auth/checkp9auth.sh
> index 4365427..4a5a7d4 100755
> --- a/testcases/kernel/security/p9auth/checkp9auth.sh
> +++ b/testcases/kernel/security/p9auth/checkp9auth.sh
> @@ -47,7 +47,6 @@ if [ $? -ne 0 ]; then
>  fi
> 
>  majfile=/sys/module/p9auth/parameters/cap_major
> -minfile=/sys/module/p9auth/parameters/cap_minor
>  if [ ! -f "$majfile" ]; then
>  	if [ $yesno -eq 1 ]; then echo
>  		echo "no"
> @@ -56,16 +55,15 @@ if [ ! -f "$majfile" ]; then
>  	fi
>  	exit 1
>  fi
> +maj=`cat $majfile`
> 
>  if [ ! -c "/dev/caphash" ]; then
>  	rm -f /dev/caphash
> -	maj=`cat $majfile`
>  	mknod /dev/caphash c $maj 0
>  fi
> 
>  if [ ! -c "/dev/capuse" ]; then
>  	rm -f /dev/capuse
> -	min=`cat $minfile`
>  	mknod /dev/capuse c $maj 1
>  fi
>  chmod ugo+w /dev/capuse


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2009-10-13 14:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08 16:59 [LTP] [PATCH 1/1] p9auth: fix a bug in the p9auth setup script Serge E. Hallyn
2009-10-13 14:43 ` Subrata Modak [this message]
2009-10-13 19:18   ` Garrett Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255445031.8438.70.camel@subratamodak.linux.ibm.com \
    --to=subrata@linux.vnet.ibm.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=serue@us.ibm.com \
    --cc=yanegomi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.