All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dustin Kirkland <kirkland@canonical.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hotplug: fix "pci_add storage if=scsi"
Date: Tue, 13 Oct 2009 11:01:24 -0500	[thread overview]
Message-ID: <1255449684.21570.24.camel@x200> (raw)
In-Reply-To: <4AD4A286.30005@codemonkey.ws>

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

On Tue, 2009-10-13 at 10:53 -0500, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
> > Explicitly add the drive to the bus of the newly created scsi adapter
> > instead of hoping that scsi_bus_legacy_handle_cmdline() picks it up
> > correctly.
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> >   
> 
> I think that this is also broken in stable-0.11.  The backport seems 
> non-trivial.  Could you take a look?

Definitely broken in stable-0.11.

I took a look at backporting this patch, but it seems that (at least) in
stable-0.11:
 * scsi_bus_legacy_handle_cmdline() doesn't exist
 * scsi_bus_new() syntax may have changed (?)
 * pci_create() syntax may have changed (?)

I'll gladly test and ack a backport ;-)


Thanks,
:-Dustin

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

      reply	other threads:[~2009-10-13 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-13 11:59 [Qemu-devel] [PATCH] hotplug: fix "pci_add storage if=scsi" Gerd Hoffmann
2009-10-13 15:53 ` Anthony Liguori
2009-10-13 16:01   ` Dustin Kirkland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255449684.21570.24.camel@x200 \
    --to=kirkland@canonical.com \
    --cc=anthony@codemonkey.ws \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.