All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alok Kataria <akataria@vmware.com>
To: Chris Wright <chrisw@sous-sol.org>
Cc: James Bottomley <James.Bottomley@suse.de>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Mike Christie <michaelc@cs.wisc.edu>,
	Bart Van Assche <bvanassche@acm.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	Matthew Wilcox <matthew@wil.cx>,
	"pv-drivers@vmware.com" <pv-drivers@vmware.com>,
	Roland Dreier <rdreier@cisco.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Chetan.Loke@Emulex.Com" <Chetan.Loke@Emulex.Com>,
	Brian King <brking@linux.vnet.ibm.com>,
	Rolf Eike Beer <eike-kernel@sf-tec.de>,
	Robert Love <robert.w.love@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Daniel Walker <dwalker@fifo99.com>, Greg KH <gregkh@suse.de>,
	"virtualization@lists.linux-foundataion.org"
	<virtualization@lists.linux-foundataion.org>
Subject: Re: SCSI driver for VMware's virtual HBA - V5.
Date: Tue, 13 Oct 2009 15:13:01 -0700	[thread overview]
Message-ID: <1255471981.12792.126.camel@ank32.eng.vmware.com> (raw)
In-Reply-To: <20091013220013.GB2908@sequoia.sous-sol.org>


On Tue, 2009-10-13 at 15:00 -0700, Chris Wright wrote:
> * Alok Kataria (akataria@vmware.com) wrote:
> > On Mon, 2009-10-12 at 22:37 -0700, Chris Wright wrote:
> > > > +     pvscsi_template.can_queue =
> > > > +             min(PVSCSI_MAX_NUM_PAGES_REQ_RING, pvscsi_ring_pages) *
> > > > +             PVSCSI_MAX_NUM_REQ_ENTRIES_PER_PAGE;
> > > > +     pvscsi_template.cmd_per_lun =
> > > > +             min(pvscsi_template.can_queue, pvscsi_cmd_per_lun);
> > > 
> > > When/how are these tunables used?  Are they still useful?
> > 
> > cmd_per_lun, is a commandline parameter.
> 
> Actually I meant how is a user supposed to use these?  They looked to me
> like tunables that were part of developing a driver that may not be
> needed any longer.  
> What are the right values, what are the tradeoffs,
> etc?  Or should they just be removed?

The defaults are the right values, and though a normal user won't change
those in practice (he can if he wants to by passing values during
insmod), a developer working on performance tuning can use it. 

So I would like to keep these tunables around as it helps any future
performance work. 

Thanks,
Alok

> 
> thanks,
> -chris


  reply	other threads:[~2009-10-13 22:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-30 18:53 SCSI driver for VMware's virtual HBA - V5 Alok Kataria
2009-09-30 18:56 ` Alok Kataria
2009-10-02  0:47 ` Chris Wright
2009-10-02  1:43   ` James Bottomley
2009-10-02  4:37     ` Alok Kataria
2009-10-06  0:30   ` Alok Kataria
2009-10-13  5:37     ` Chris Wright
2009-10-13 21:28       ` Alok Kataria
2009-10-13 22:00         ` Chris Wright
2009-10-13 22:13           ` Alok Kataria [this message]
2009-10-13 21:51       ` SCSI driver for VMware's virtual HBA - V6 Alok Kataria
2009-10-13 21:51         ` Alok Kataria
2009-10-13 23:41         ` Chris Wright
2009-10-13 23:41           ` Chris Wright
2009-10-28 20:28           ` Alok Kataria
2009-10-13 14:35     ` SCSI driver for VMware's virtual HBA - V5 James Bottomley
2009-10-13 14:35     ` James Bottomley
2009-10-13 16:45       ` Jeremy Fitzhardinge
2009-10-13 16:45       ` Jeremy Fitzhardinge
2009-10-13 17:18         ` Alok Kataria
2009-10-13 17:18         ` Alok Kataria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255471981.12792.126.camel@ank32.eng.vmware.com \
    --to=akataria@vmware.com \
    --cc=Chetan.Loke@Emulex.Com \
    --cc=James.Bottomley@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=brking@linux.vnet.ibm.com \
    --cc=bvanassche@acm.org \
    --cc=chrisw@sous-sol.org \
    --cc=dwalker@fifo99.com \
    --cc=eike-kernel@sf-tec.de \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=michaelc@cs.wisc.edu \
    --cc=pv-drivers@vmware.com \
    --cc=randy.dunlap@oracle.com \
    --cc=rdreier@cisco.com \
    --cc=robert.w.love@intel.com \
    --cc=virtualization@lists.linux-foundataion.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.