All of lore.kernel.org
 help / color / mirror / Atom feed
From: iceberg <strakh@ispras.ru>
To: Benjamin Kong <benjamin_kong@ali.com.tw>,
	Samuel Ortiz <samuel@sortiz.org>,
	rda-users@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [BUG] ali-ircc.c: get spin_lock twice
Date: Wed, 14 Oct 2009 12:14:05 +0000	[thread overview]
Message-ID: <1255522445.31793.0@pamir> (raw)

	KERNEL_VERSION: 2.6.31
	DESCRIBE:
Driver reports/drivers/net/irda/ali-ircc.c  - get spin_lock twice

drivers/net/irda/ali-ircc.c:
2028static int ali_ircc_net_ioctl(struct net_device *dev, struct ifreq 
*rq, int cmd)

...
2056		spin_lock_irqsave(&self->lock, flags);
2057		ali_ircc_change_speed(self, irq->ifr_baudrate);
...

Path to second spin_lock_irqsave(&self->lock, flags) 
 from ali_ircc_change_speed:
1. ali_ircc_change_speed calls ali_ircc_sir_change_speed ./drivers/net/
irda/ali-ircc.c:999
2. ali_ircc_sir_change_speed calls spin_lock_irqsave at ./drivers/net/
irda/ali-ircc.c:1084:

1050static void ali_ircc_sir_change_speed(struct ali_ircc_cb *priv, 
__u32 speed)
1084        spin_lock_irqsave(&self->lock, flags);

Found by: Linux Driver Verification project


                 reply	other threads:[~2009-10-14  8:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255522445.31793.0@pamir \
    --to=strakh@ispras.ru \
    --cc=benjamin_kong@ali.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rda-users@lists.sourceforge.net \
    --cc=samuel@sortiz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.