From: Artem Bityutskiy <dedekind1@gmail.com>
To: vimal singh <vimal.newwork@gmail.com>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Akinobu Mita <akinobu.mita@gmail.com>
Subject: Re: [PATCH] MTD: Add nand_ecc test module
Date: Thu, 15 Oct 2009 09:36:30 +0300 [thread overview]
Message-ID: <1255588590.32489.209.camel@localhost> (raw)
In-Reply-To: <ce9ab5790910142205u41f6baf3v570515eec116edb3@mail.gmail.com>
On Thu, 2009-10-15 at 10:35 +0530, vimal singh wrote:
> On Wed, Oct 14, 2009 at 9:11 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> > On Tue, 2009-10-13 at 18:58 +0900, Akinobu Mita wrote:
> >> > This should not be needed. MTD tests are always compiled as modules,
> >> > so you should not have copilation errors. And if MTD NAND support is
> >> > not present, modprobe will just fail.
> >>
> >> nand_calculate_ecc and nand_correct_data needs CONFIG_MTD_NAND=y|m,
> >> otherwise it will get link error:
> >>
> >> ERROR: "__nand_correct_data" [drivers/mtd/tests/nand_ecc-test.ko] undefined!
> >> ERROR: "__nand_calculate_ecc" [drivers/mtd/tests/nand_ecc-test.ko] undefined!
> >
> > How about splitting tests on 2 parts - one part which does not require
> > NAND, and one which does, and make the second part compile only if NAND
> > is enabled ("depends" operator in Kconfig) ?
>
> I thought purpose of this test was to test correctness of
> 'nand_calculate_ecc' and 'nand_correct_data' functions (i.e. algos),
> which are only compiled and available when NAND is enabled.
That is exactly what I meant as well.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2009-10-15 6:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 9:54 [PATCH] MTD: Add nand_ecc test module Akinobu Mita
2009-10-11 13:39 ` Artem Bityutskiy
2009-10-13 9:58 ` Akinobu Mita
2009-10-14 15:41 ` Artem Bityutskiy
2009-10-15 5:05 ` vimal singh
2009-10-15 6:36 ` Artem Bityutskiy [this message]
2009-10-15 6:42 ` vimal singh
2009-10-15 6:50 ` Artem Bityutskiy
2009-10-15 8:53 ` vimal singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255588590.32489.209.camel@localhost \
--to=dedekind1@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vimal.newwork@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.