From: Mark McLoughlin <markmc@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, Ulrich Obergfell <uobergfe@redhat.com>
Subject: Re: [PATCH] kvm: fix MSR_COUNT for kvm_arch_save_regs()
Date: Fri, 16 Oct 2009 14:43:14 +0100 [thread overview]
Message-ID: <1255700594.3072.25.camel@blaa> (raw)
In-Reply-To: <20091014180227.GQ24126@blackpad.lan.raisama.net>
On Wed, 2009-10-14 at 15:02 -0300, Eduardo Habkost wrote:
> A new register was added to the load/save list on commit
> d283d5a65a2bdcc570065267be21848bd6fe3d78, but MSR_COUNT was not updated, leading
> to potential stack corruption on kvm_arch_save_regs().
>
> The following registers are saved by kvm_arch_save_regs():
>
> 1) MSR_IA32_SYSENTER_CS
> 2) MSR_IA32_SYSENTER_ESP
> 3) MSR_IA32_SYSENTER_EIP
> 4) MSR_STAR
> 5) MSR_IA32_TSC
> 6) MSR_VM_HSAVE_PA
> 7) MSR_CSTAR (x86_64 only)
> 8) MSR_KERNELGSBASE (x86_64 only)
> 9) MSR_FMASK (x86_64 only)
> 10) MSR_LSTAR (x86_64 only)
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Forgot:
Reported-by: Ulrich Obergfell <uobergfe@redhat.com>
Looks like the fix is needed on both stable-0.10 and stable-0.11 as well
as master
Cheers,
Mark.
prev parent reply other threads:[~2009-10-16 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 18:02 [PATCH] kvm: fix MSR_COUNT for kvm_arch_save_regs() Eduardo Habkost
2009-10-15 15:59 ` Marcelo Tosatti
2009-10-16 13:43 ` Mark McLoughlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255700594.3072.25.camel@blaa \
--to=markmc@redhat.com \
--cc=avi@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.