From: Timo Sirainen <tss@iki.fi>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc/pid/cmdline: Handle invalid cmdline change failures correctly.
Date: Fri, 16 Oct 2009 17:59:20 -0400 [thread overview]
Message-ID: <1255730360.4605.754.camel@timo-desktop> (raw)
In-Reply-To: <20091016145431.ed00922e.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Fri, 2009-10-16 at 14:54 -0700, Andrew Morton wrote:
> On Sat, 03 Oct 2009 00:07:12 -0400
> Timo Sirainen <tss@iki.fi> wrote:
>
> > Handle access_process_vm() failures correctly in /proc/pid/cmdline.
> > This bug might have leaked kernel memory to userspace.
> >
>
> And I don't see what it is. afacit the current code is correct.
It is, sorry. Someone had mentioned access_process_vm() could fail by
returning negative values and I didn't verify that myself before sending
this "fix".
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-10-16 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-03 4:07 [PATCH] proc/pid/cmdline: Handle invalid cmdline change failures correctly Timo Sirainen
2009-10-16 21:54 ` Andrew Morton
2009-10-16 21:59 ` Timo Sirainen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255730360.4605.754.camel@timo-desktop \
--to=tss@iki.fi \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.