All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: David Miller <davem@davemloft.net>
Cc: phcoder@gmail.com, bean123ch@gmail.com, grub-devel@gnu.org
Subject: Re: powerpc/sparc problems
Date: Fri, 16 Oct 2009 21:21:36 -0400	[thread overview]
Message-ID: <1255742496.2746.26.camel@mj> (raw)
In-Reply-To: <20091016.054440.193711272.davem@davemloft.net>

On Fri, 2009-10-16 at 05:44 -0700, David Miller wrote:
> From: Pavel Roskin <proski@gnu.org>
> Date: Thu, 15 Oct 2009 18:41:41 -0400
> 
> > This makes me think that checks for __bswapsi2 and  __bswapdi2 will fail
> > on Sparc64, even if those functions are present and even if
> > --disable-werror is used.
> 
> They worked perfectly fine for me on a real system with
> a real compiler and glibc.
> 
> If you're going to use cross compilation to test, use
> a full cross toolset and glibc build not some hacked
> up uclibc thing.

I have tested the current GRUB on PowerPC.  It's Fedora 11 with a real
glibc.  I added __ashldi3 to the arguments of AC_CHECK_FUNCS.  The check
fails.  Yet __ashldi3 is present in libgcc and is exported
unconditionally.

The reason is that -nostdlib is added to CFLAGS immediately above 
AC_CHECK_FUNCS.  -nostdlib disables linking against libgcc.

I believe the checks for __bswapsi2 __bswapdi2 would fail on sparc64 for
the same reason.

Also, I believe the effect of -Werror on the test will be seen on
sparc64.  Adding -Werror should be after all tests and there should be a
big warning in configure.ac telling not to add tests after that point.

> I also believe that even if it still fails for you,
> native building is more important to work than cross
> building situations.

It is a native build and the current code.

The whole reason I removed the checks is because they stopped working
correctly when the target libc requirement was eliminated.  Restoring
the checks without removing -nostdlib not going to help.

I'm surprised that my code is being reverted immediately before the
release and the result is not tested.  It's one thing to revert the code
that has just been committed, and it's entirely different when the code
has been in the repository for months.

-- 
Regards,
Pavel Roskin



  parent reply	other threads:[~2009-10-17  1:21 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12  8:55 powerpc/sparc problems Felix Zielcke
2009-10-12  9:05 ` David Miller
2009-10-12  9:42   ` Felix Zielcke
2009-10-12  9:56   ` Vladimir 'phcoder' Serbinenko
2009-10-12 10:11     ` David Miller
2009-10-12 10:27     ` Felix Zielcke
2009-10-12  9:26 ` Vladimir 'phcoder' Serbinenko
2009-10-12  9:33 ` Felix Zielcke
2009-10-20 18:07   ` rubisher
2009-10-20 20:24     ` Vladimir 'phcoder' Serbinenko
2009-10-21 15:59       ` rubisher
2009-10-12  9:58 ` Bean
2009-10-12 10:14   ` David Miller
2009-10-12 10:26     ` Vladimir 'phcoder' Serbinenko
2009-10-12 10:28       ` David Miller
2009-10-12 15:29         ` Pavel Roskin
2009-10-12 15:45           ` Vladimir 'phcoder' Serbinenko
2009-10-12 22:03             ` Pavel Roskin
2009-10-12 23:39             ` David Miller
2009-10-15 11:58         ` Vladimir 'phcoder' Serbinenko
2009-10-15 22:41           ` Pavel Roskin
2009-10-16 12:44             ` David Miller
2009-10-16 14:10               ` Pavel Roskin
2009-10-17  1:21               ` Pavel Roskin [this message]
2009-10-17  9:08                 ` Vladimir 'phcoder' Serbinenko
2009-10-17 10:11                 ` Robert Millan
2009-10-20 21:38                   ` [PATCH] auto-generate libgcc.h Robert Millan
2009-10-21  6:28                     ` Vladimir 'phcoder' Serbinenko
2009-10-21 15:55                       ` rubisher
2009-10-21 21:00                         ` Vladimir 'phcoder' Serbinenko
2009-10-23 16:19                           ` rubisher
2009-10-12 10:31     ` powerpc/sparc problems Bean
2009-10-12 11:07       ` David Miller
2009-10-12 14:05         ` Bean
2009-10-14 16:37       ` Robert Millan
2009-10-21 16:03   ` rubisher
2009-10-21 20:15     ` Bean
2009-10-28 10:24 ` Felix Zielcke
2009-10-28 10:29   ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2009-10-22  9:12 rubisher
2009-10-22  9:31 ` Bean
2009-10-23 20:34   ` rubisher
2009-10-24  6:13     ` Bean
2009-10-25 15:22       ` rubisher
2009-10-25 15:57         ` Bean
2009-10-26 21:06           ` rubisher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255742496.2746.26.camel@mj \
    --to=proski@gnu.org \
    --cc=bean123ch@gmail.com \
    --cc=davem@davemloft.net \
    --cc=grub-devel@gnu.org \
    --cc=phcoder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.