From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mz8nq-0004TJ-2X for mharc-grub-devel@gnu.org; Sat, 17 Oct 2009 08:54:34 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mz8nn-0004Q5-H9 for grub-devel@gnu.org; Sat, 17 Oct 2009 08:54:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mz8nj-0004KJ-OZ for grub-devel@gnu.org; Sat, 17 Oct 2009 08:54:31 -0400 Received: from [199.232.76.173] (port=52809 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mz8nj-0004K5-Hv for grub-devel@gnu.org; Sat, 17 Oct 2009 08:54:27 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:57319) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mz8nj-00025i-00 for grub-devel@gnu.org; Sat, 17 Oct 2009 08:54:27 -0400 Received: from [85.180.43.35] (e180043035.adsl.alicedsl.de [85.180.43.35]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0MRBAV-1MpXNm41pn-00UlGt; Sat, 17 Oct 2009 14:54:26 +0200 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <4AD9B5F0.40304@parallels.com> References: <4AD9B5F0.40304@parallels.com> Content-Type: text/plain; charset="UTF-8" Date: Sat, 17 Oct 2009 14:54:24 +0200 Message-Id: <1255784064.3373.23.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX185Ay8n7pXCKee3P89nxDKSpX0AVewhR1Z9ICT ONefX0kMYqPleh4irAihWcq8QDQ2ZLOcizYcfzpEonZQ1ma3Bw g/7tP3hi1+XNKG5rrWnSkDEVhNsUNfd X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [patch] deadloop in grub_ext2_iterate_dir X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2009 12:54:31 -0000 Am Samstag, den 17.10.2009, 16:17 +0400 schrieb Vasily Averin: > + if (grub_le_to_cpu16 (dirent.direntlen) == 0) > + return 0; > + > if (dirent.namelen != 0) For consistency we should either always use the grub_Xe_to_cpuYZ functions or never when checking for a 0 value. Oh and in my first reply I forgot to tell you, that we prefer to have GNU Changelog entries sent along with patches. A git Signed-off-by line is useless. We use SVN not git as our main repository. -- Felix Zielcke Proud Debian Maintainer and GNU GRUB developer