All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Fix compile errors found by new ppc64e_defconfig
Date: Mon, 19 Oct 2009 10:58:28 +1100	[thread overview]
Message-ID: <1255910308.4192.8.camel@concordia> (raw)
In-Reply-To: <1255712717-21221-2-git-send-email-galak@kernel.crashing.org>

[-- Attachment #1: Type: text/plain, Size: 2285 bytes --]

On Fri, 2009-10-16 at 12:05 -0500, Kumar Gala wrote:
> Fix the following 3 issues:
> 
> arch/powerpc/kernel/process.c: In function 'arch_randomize_brk':
> arch/powerpc/kernel/process.c:1183: error: 'mmu_highuser_ssize' undeclared (first use in this function)
> arch/powerpc/kernel/process.c:1183: error: (Each undeclared identifier is reported only once
> arch/powerpc/kernel/process.c:1183: error: for each function it appears in.)
> arch/powerpc/kernel/process.c:1183: error: 'MMU_SEGSIZE_1T' undeclared (first use in this function)
> 
> In file included from arch/powerpc/kernel/setup_64.c:60:
> arch/powerpc/include/asm/mmu-hash64.h:132: error: redefinition of 'struct mmu_psize_def'
> arch/powerpc/include/asm/mmu-hash64.h:159: error: expected identifier or '(' before numeric constant
> arch/powerpc/include/asm/mmu-hash64.h:396: error: conflicting types for 'mm_context_t'
> arch/powerpc/include/asm/mmu-book3e.h:184: error: previous declaration of 'mm_context_t' was here
> 
> cc1: warnings being treated as errors
> arch/powerpc/kernel/pci_64.c: In function 'pcibios_unmap_io_space':
> arch/powerpc/kernel/pci_64.c:100: error: unused variable 'res'
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>  arch/powerpc/kernel/pci_64.c   |    2 ++
>  arch/powerpc/kernel/process.c  |    2 +-
>  arch/powerpc/kernel/setup_64.c |    1 -
>  3 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/pci_64.c b/arch/powerpc/kernel/pci_64.c
> index ba949a2..ccf56ac 100644
> --- a/arch/powerpc/kernel/pci_64.c
> +++ b/arch/powerpc/kernel/pci_64.c
> @@ -97,7 +97,9 @@ int pcibios_unmap_io_space(struct pci_bus *bus)
>  	 * to do an appropriate TLB flush here too
>  	 */
>  	if (bus->self) {
> +#ifdef CONFIG_PPC_STD_MMU_64
>  		struct resource *res = bus->resource[0];
> +#endif
>  
>  		pr_debug("IO unmapping for PCI-PCI bridge %s\n",
>  			 pci_name(bus->self));
104 
105 #ifdef CONFIG_PPC_STD_MMU_64                                                
106                 __flush_hash_table_range(&init_mm, res->start + _IO_BASE,
107                                          res->end + _IO_BASE + 1);
108 #endif
109		return 0;
110	 }

So just expand the ifdef around the pr_debug()?

cheers

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-10-18 23:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16 17:05 [PATCH] powerpc: Add a Book-3E 64-bit defconfig Kumar Gala
2009-10-16 17:05 ` [PATCH] powerpc: Fix compile errors found by new ppc64e_defconfig Kumar Gala
2009-10-18 23:58   ` Michael Ellerman [this message]
2009-10-19  4:24     ` Benjamin Herrenschmidt
2009-10-16 17:22 ` [PATCH] powerpc: Add a Book-3E 64-bit defconfig Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255910308.4192.8.camel@concordia \
    --to=michael@ellerman.id.au \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.