From: Daniel Walker <dwalker@fifo99.com>
To: Erwan Velu <erwanaliasr1@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] dmi_check_system can generate Warnings when no DMI table is present
Date: Fri, 23 Oct 2009 08:09:36 -0700 [thread overview]
Message-ID: <1256310576.10493.78.camel@desktop> (raw)
In-Reply-To: <4AE1C5C6.7000103@gmail.com>
On Fri, 2009-10-23 at 17:03 +0200, Erwan Velu wrote:
> Daniel Walker a écrit :
> > [...]
> > It's your defect, so you can still try to fix it (unless the "xen
> > people" or someone else beats you to it.)
> >
> > It looks like on a normal system dmi_scan_machine() gets called very
> > early in setup_arch() arch/x86/kernel/setup.c . A possible good fix
> > might be to add a dmi_disable() into the dmi driver that just shuts off
> > dmi, and run that in xen_arch_setup() in arch/x86/xen/setup.c
> Could it make sense having this patch (I can work on it) while keeping
> my previous patch ?
> Does it make sense keeping the default return value I've been adding
> when no dmi table is found ?
Ingo mentioned that the returning mechanism your adding was left out
intentionally to catch this error, so I don't think your original patch
could be included ..
Daniel
next prev parent reply other threads:[~2009-10-23 15:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 9:34 [PATCH] dmi_check_system can generate Warnings when no DMI table is present Erwan Velu
2009-10-23 10:08 ` Daniel Walker
2009-10-23 10:34 ` Erwan Velu
2009-10-23 10:42 ` Daniel Walker
2009-10-23 10:46 ` Erwan Velu
2009-10-23 11:00 ` Ingo Molnar
2009-10-23 11:03 ` Ingo Molnar
2009-10-23 11:49 ` Erwan Velu
2009-10-23 12:47 ` Daniel Walker
2009-10-23 15:03 ` Erwan Velu
2009-10-23 15:09 ` Daniel Walker [this message]
2009-10-23 15:30 ` Ingo Molnar
2009-10-23 17:00 ` Jeremy Fitzhardinge
2009-10-23 17:04 ` Ingo Molnar
2009-10-23 17:31 ` Jeremy Fitzhardinge
2009-10-23 16:57 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256310576.10493.78.camel@desktop \
--to=dwalker@fifo99.com \
--cc=erwanaliasr1@gmail.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.