From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N1zXG-0000N0-Nr for mharc-grub-devel@gnu.org; Sun, 25 Oct 2009 05:37:14 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N1zXD-0000Kf-JC for grub-devel@gnu.org; Sun, 25 Oct 2009 05:37:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N1zX8-0000Hm-L2 for grub-devel@gnu.org; Sun, 25 Oct 2009 05:37:11 -0400 Received: from [199.232.76.173] (port=55735 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N1zX8-0000HU-F3 for grub-devel@gnu.org; Sun, 25 Oct 2009 05:37:06 -0400 Received: from moutng.kundenserver.de ([212.227.126.188]:64972) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N1zX8-0004BI-09 for grub-devel@gnu.org; Sun, 25 Oct 2009 05:37:06 -0400 Received: from [85.180.33.255] (e180033255.adsl.alicedsl.de [85.180.33.255]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0LfWo9-1MR14Z1eXZ-00p0ZL; Sun, 25 Oct 2009 10:37:02 +0100 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <4AE41A15.7050504@gmail.com> References: <20091025003617.GH28534@riva.ucam.org> <4AE41A15.7050504@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Sun, 25 Oct 2009 10:37:01 +0100 Message-ID: <1256463421.3277.14.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1+rc75Pc9jllcGBuYW2Le6Wq8HApQ3MNP4pcpX RJXGRrShRBDJWAVXkbeMYlIcOroIG05Y41PUjhhtU64aHCoTyZ XBKC4rGkcuGyuPfc0ZyhA== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Support RAID on virtio devices, and others X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Oct 2009 09:37:11 -0000 Am Sonntag, den 25.10.2009, 10:27 +0100 schrieb Vladimir 'phcoder' Serbinenko: > > find_root_device in util/getroot.c seemed to be exactly what I > wanted: > > it just trawls /dev for the appropriate major and minor numbers. > This > > code is not performance-critical, so that should be fine. > Not true. Even in current state grub-mkconfig is taking considerable > time to complete on my system with numerous kernels. Unless someone > implements a cache (it can be invalidated after 5 minutes) not to go > through the same probing procedure on every grub-probe call I object > against adding any additional delay in probing procedure We have a bug report in Debian[0] open that grub-probe is very slow due to the use of ioctl(BLKFLSBUF) A comment above it says this is needed due to a bug in the Linux kernel. Is there a safe way to check if this is still needed with a recent Kernel? This seems to be added 2003, so things could have changed now a bit. [0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=508834 -- Felix Zielcke Proud Debian Maintainer and GNU GRUB developer