From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] davinci timer.c: Remove volatiles and memory mapped structures
Date: Mon, 26 Oct 2009 09:42:56 -0500 [thread overview]
Message-ID: <1256568176.11916.3052.camel@localhost.localdomain> (raw)
In-Reply-To: <4AE5B208.7080304@gefanuc.com>
Hi Nick,
> --- a/cpu/arm926ejs/davinci/timer.c
> +++ b/cpu/arm926ejs/davinci/timer.c
> @@ -1,4 +1,8 @@
> /*
> + * Copyright (C) 2009 Nick Thompson, GE Fanuc, Ltd. <nick.thompson@gefanuc.com>
> + *
> + * Coding style changes. Use writel and readl for hardware accesses.
> + *
> * (C) Copyright 2003
> * Texas Instruments <www.ti.com>
> *
The change looks good to me, but I don't think your copyright should be
added for such a trivial change. There are already 6 separate
copyrights for a relatively simple 100 lines of code:)
Best,
Peter
next prev parent reply other threads:[~2009-10-26 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 14:28 [U-Boot] [PATCH] davinci timer.c: Remove volatiles and memory mapped structures Nick Thompson
2009-10-26 14:42 ` Peter Tyser [this message]
2009-10-26 14:48 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256568176.11916.3052.camel@localhost.localdomain \
--to=ptyser@xes-inc.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.