Re: [Qemu-devel] [PATCH 5/5] tap: drain queue in tap_send()

[Mark McLoughlin <markmc@redhat.com>]

On Fri, 2009-10-30 at 11:21 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > Okay, let's try re-enabling the drain-entire-queue behaviour, with a
> > difference - before each subsequent packet, use qemu_can_send_packet()
> > to check that we can send it. This is similar to how we check before
> > polling the tap fd and avoids having to drop a packet if the receiver
> > cannot handle it.
> >
> > This patch should be a performance improvement since we no longer have
> > to go through the mainloop for each packet.
> >
> > Signed-off-by: Mark McLoughlin <markmc@redhat.com>
> >   
> 
> Could you rebase and rend this patch against master?  I've got 1-4 in 
> staging.
> 
> The GSO changes make resolving this non trivial (for me at least :-)).

Um, you've lost me :-)

You've got it in staging AFAICS, and anyway ... 5/5 is mostly a revert
of 1/5, so if 1/5 applied so should 5/5

What's in staging looks fine to me, except it doesn't build because of
problems with other patches

Thanks,
Mark.