From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N3woF-0006N0-TX for mharc-grub-devel@gnu.org; Fri, 30 Oct 2009 15:06:51 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3woD-0006Ls-Js for grub-devel@gnu.org; Fri, 30 Oct 2009 15:06:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3wo9-0006JL-08 for grub-devel@gnu.org; Fri, 30 Oct 2009 15:06:49 -0400 Received: from [199.232.76.173] (port=59363 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3wo8-0006JB-Lk for grub-devel@gnu.org; Fri, 30 Oct 2009 15:06:44 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:52414) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N3wo7-00067A-Rf for grub-devel@gnu.org; Fri, 30 Oct 2009 15:06:44 -0400 Received: from [85.180.58.146] (e180058146.adsl.alicedsl.de [85.180.58.146]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0M8MHm-1MHByc0AZm-00w3Dx; Fri, 30 Oct 2009 20:06:40 +0100 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20091030185759.GA30150@thorin> References: <57a6d2110910290758i23de79c1y2b87513f674023b@mail.gmail.com> <20091030185759.GA30150@thorin> Content-Type: text/plain; charset="UTF-8" Date: Fri, 30 Oct 2009 20:06:39 +0100 Message-ID: <1256929599.3337.14.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1+oirmyCABQxWp3Gq+5lOLGFa5xKO94dk9ubSp 6f7PrI2zouZCOFloSXkl0UgiH9px+Erq2X5o6Pm89KmmmG6+Bz 2ZfieWTRnINufCxL2PYIQ== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [patch] grub incorrectly identifies ext3 as fat X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2009 19:06:50 -0000 Am Freitag, den 30.10.2009, 19:57 +0100 schrieb Robert Millan: > On Thu, Oct 29, 2009 at 02:58:09PM +0000, Andrew Clausen wrote: > > Hi all, > > > > grub (both the boot loader, and grub-probe) incorrectly identifies my > > ext3 partition as containing a fat file system. This means it can't > > boot without manual tweaking. The problem is caused by stale fat > > signatures... this is probably a common problem, as mke2fs often > > doesn't wipe old signatures. > > > > I wrote a patch. In order for a file system to be considered > > detected, dir() must not only succeed, it also must find at least one > > file or directory. This is pretty effective at ruling out misdetecting > > a filesystem based on a stale signature that wasn't wiped by mkfs. > > We already had code for this, see: > > 2009-09-05 Robert Millan > > * util/grub-probe.c (probe): Comment out buggy codepath, which > was unexpectedly enabled by Colin Watson's 2009-09-02 fix. This > should be re-enabled after 1.97. The problem with this (well not the problem why this was reverted) is that would just abort with an error if grub-probe detects the wrong filesystem. Ok would still be better then as currently embeding the wrong fs module to core.img -- Felix Zielcke Proud Debian Maintainer and GNU GRUB developer