From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Wysochanski Date: Sun, 01 Nov 2009 15:09:54 -0500 Subject: [PATCH]: Enable snapshots of mirrors In-Reply-To: <87iqdusaf6.fsf@twilight.int.mornfall.net.> References: <1256237661.14726.3.camel@hydrogen.msp.redhat.com> <87iqdusaf6.fsf@twilight.int.mornfall.net.> Message-ID: <1257106194.2407.8.camel@f10-node1> List-Id: To: lvm-devel@redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, 2009-11-01 at 13:21 +0100, Petr Rockai wrote: > Hi, > > it would be great if you could convert your tests into actual testcase code, > maybe gathered all under test/t-snapshots-of-mirrors.sh -- this would help > prevent any possible regressions in the future. It would also mean we remember > all the information you needed to gather to conduct these tests. > > May you need any assistance with writing the tests, please don't hesitate to > contact me (IRC probably works best). > Thanks Petr for mentioning this - we need to encourage unit tests being written. I second Petr's note as it will help us all in the long run.