From: James Bottomley <James.Bottomley@suse.de>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-scsi@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] strstrip incorrectly marked __must_check
Date: Tue, 03 Nov 2009 13:11:42 -0600 [thread overview]
Message-ID: <1257275502.2454.2.camel@mulgrave.site> (raw)
In-Reply-To: <20091103190420.GY10555@parisc-linux.org>
On Tue, 2009-11-03 at 12:04 -0700, Matthew Wilcox wrote:
> static inline void strsrip_tail(char *str)
> {
> - char *x __used;
> - x = strstrip(str);
> + char *x = strstrip(str);
> + BUG_ON(x != str);
> }
Please, no. I said didn't care about leading whitespace ... I didn't
say there wasn't any.
James
next prev parent reply other threads:[~2009-11-03 19:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 18:38 [PATCH] strstrip incorrectly marked __must_check James Bottomley
2009-11-03 18:59 ` Andrew Morton
2009-11-03 19:04 ` Matthew Wilcox
2009-11-03 19:06 ` KOSAKI Motohiro
2009-11-03 19:06 ` KOSAKI Motohiro
2009-11-03 19:10 ` Alan Cox
2009-11-03 19:11 ` James Bottomley [this message]
2009-11-03 19:10 ` James Bottomley
2009-11-03 19:12 ` Alan Cox
2009-11-03 19:58 ` KOSAKI Motohiro
2009-11-23 13:04 ` Michael Holzheu
2009-11-24 8:55 ` KOSAKI Motohiro
2009-11-24 9:09 ` Michael Holzheu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257275502.2454.2.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.