From: jassisinghbrar@gmail.com
To: linux-samsung-soc@vger.kernel.org
Cc: Jassi Brar <jassi.brar@samsung.com>
Subject: Revised patches for PCM Controller driver
Date: Wed, 4 Nov 2009 17:27:44 +0900 [thread overview]
Message-ID: <1257323264-18363-1-git-send-email-jassisinghbrar@gmail.com> (raw)
From: Jassi Brar <jassi.brar@samsung.com>
Acting upon the inputs given by Mark and Ben, I have revised the code.
A few points to be noted:-
1) The prefix s3c24xx_pcm_ in the platform driver has been changed to
more neutral s3c_audio_
2) ALSA platform driver s3c24xx-pcm.c/h have been renamed s3c-audio.c/h
since the 'pcm' part will cause ambiguity once PCM Controller driver
is added. Also, since it is not just for 24xx, the part is dropped
from the prefix.
Ofcourse, evey dependent code has been modified to include differently
named, otherwise same, header s3c-audio.h
3) arch/arm/plat-s3c/include/plat/audio.h has been restored by with only
necessary data structures.
Having callbacks to configure controller pins appropriately is necessary
if the driver is to handle more than one SoC type.
Currently only callback to configure gpios has been defined, the data
structure will grow as and when needed.
4) The PCM controller platform devices have been defined in the apparently
common arch/arm/plat-s3c64xx/dev-audio.c rather than a new PCM specific one.
5) Here comes the tricky one.
Breaking away from S3C convention, I have defined PCM controller register
offsets and bit fields in sound/soc/s3c24xx/s3c-pcm.h instead of some
platform/arch specific header.
The reason for the move is that usually the device controllers depend upon
platform type only as far as their base mapping address goes. Otherwise
just one or two 'types' of same devices serve most SoCs.
Having those definitions besides the driver helps avoid copyng the same
definitions for each platform that essentially have the same device controller.
Regards.
next reply other threads:[~2009-11-04 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 8:27 jassisinghbrar [this message]
2009-11-04 9:33 ` Revised patches for PCM Controller driver Ben Dooks
2009-11-04 12:16 ` jassi brar
2009-11-04 11:05 ` Mark Brown
2009-11-04 12:14 ` jassi brar
2009-11-04 14:03 ` Mark Brown
2009-11-06 2:29 ` When to post patches to this list or upstream Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257323264-18363-1-git-send-email-jassisinghbrar@gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=jassi.brar@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.