From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N5diI-0002XW-0c for mharc-grub-devel@gnu.org; Wed, 04 Nov 2009 06:07:42 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5diE-0002Wt-Qb for grub-devel@gnu.org; Wed, 04 Nov 2009 06:07:38 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5di9-0002Vy-7A for grub-devel@gnu.org; Wed, 04 Nov 2009 06:07:37 -0500 Received: from [199.232.76.173] (port=43037 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5di9-0002Vv-0B for grub-devel@gnu.org; Wed, 04 Nov 2009 06:07:33 -0500 Received: from moutng.kundenserver.de ([212.227.126.177]:51813) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N5di8-0004cl-AM for grub-devel@gnu.org; Wed, 04 Nov 2009 06:07:32 -0500 Received: from [85.180.49.197] (e180049197.adsl.alicedsl.de [85.180.49.197]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0McAb5-1MpM0r3myN-00Jfgs; Wed, 04 Nov 2009 12:07:31 +0100 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: References: <1251463992.2547.24.camel@fz.local> <20090828162828.GB14976@thorin> <1251482319.2547.48.camel@fz.local> <20090828235514.GA17856@thorin> <1251532275.2624.2.camel@fz.local> <1257089982.3407.1.camel@fz.local> <20091101220443.GA10713@thorin> <1257152083.3220.0.camel@fz.local> <3dcabc6941f94354cfb8f8ba8422a07d@scarlet.be> <1257244422.3366.2.camel@fz.local> <9780cc18280c05eadda3ae88117390eb@scarlet.be> <1257257373.3366.3.camel@fz.local> Content-Type: text/plain; charset="UTF-8" Date: Wed, 04 Nov 2009 12:07:29 +0100 Message-ID: <1257332849.5000.54.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX19w2ghuSTApcjIhRdEgEBp6HVQnVYQFykYuxDF 6paajme8ANWpEypZRfhqkI7buVgkf3dfdatyoZzHvW8FKss0Ad souJJDK7hu42BkUxXIubA== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATH] grub-mkrelpath X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2009 11:07:39 -0000 Am Mittwoch, den 04.11.2009, 10:55 +0100 schrieb rubisher: > > Right trunk contains my -I($srcdir)/include fix. > > merged now. > Sorry I don't agree with your fix: As you might have thought already from the following sentence, I already suspected that it's not the proper way. By the way this topic really belongs to the -nostdinc Thread from Robert. This is not at all specific to my grub-mkrelpath. At least this fixed building with a seperate build directory. > > > > But I still have the feeling using -isystem is wrong at all or at least > > the =. > Well as far as I understand, yes for cross-compiling that would make stuff > easier? > > A quick look at linux kernel build, it shows that also use -isystem but > not yet with '=' option so may be my previous patch would be more relevant. > > I let you appreciate. IMO we should use the same approach as Linux kernel does. Using -isystem just for the gcc include headers. I don't think gcc should treat our own headers as system headers. > Tx, > J. > > PS: any idea where (in which part of this proj) should I have a look to > learn why ofs doesn't reach to find disks and their structures?) > No clue. Better ask such questions in a seperate mail, not hidden in a thread which has nothing to do with this. The chances are much higer that then who can answer the qestion will read it. -- Felix Zielcke Proud Debian Maintainer and GNU GRUB developer