From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/mm: Remove debug context clamping from nohash code
Date: Thu, 05 Nov 2009 16:21:53 +1100 [thread overview]
Message-ID: <1257398513.13611.92.camel@pasglop> (raw)
In-Reply-To: <6BAA37ED-F9DB-43A6-867B-B63D65926185@kernel.crashing.org>
On Wed, 2009-11-04 at 23:16 -0600, Kumar Gala wrote:
> On Nov 4, 2009, at 5:39 PM, Benjamin Herrenschmidt wrote:
>
> > I inadvertently left that debug code enabled, causing the number of
> > contexts to be clamped to 31 which is going to slow things down on
> > 4xx and just plain breaks 8xx
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
> > arch/powerpc/mm/mmu_context_nohash.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/mm/mmu_context_nohash.c b/arch/powerpc/mm/
> > mmu_context_nohash.c
> > index c2f93dc..be4f34c 100644
> > --- a/arch/powerpc/mm/mmu_context_nohash.c
> > +++ b/arch/powerpc/mm/mmu_context_nohash.c
> > @@ -25,8 +25,8 @@
> > * also clear mm->cpu_vm_mask bits when processes are migrated
> > */
> >
> > -#define DEBUG_MAP_CONSISTENCY
> > -#define DEBUG_CLAMP_LAST_CONTEXT 31
> > +//#define DEBUG_MAP_CONSISTENCY
> > +//#define DEBUG_CLAMP_LAST_CONTEXT 31
> > //#define DEBUG_HARDER
> >
> > /* We don't use DEBUG because it tends to be compiled in always
> > nowadays
>
> Can you send this to stable.
No need. .31 doesn't have the clamp, it went in afterward afaik
(my bad) though stable does have DEBUG_MAP_CONSISTENCY which you
may want to remove for perfs.
Cheers,
Ben.
prev parent reply other threads:[~2009-11-05 5:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 23:39 [PATCH] powerpc/mm: Remove debug context clamping from nohash code Benjamin Herrenschmidt
2009-11-05 5:16 ` Kumar Gala
2009-11-05 5:21 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257398513.13611.92.camel@pasglop \
--to=benh@au1.ibm.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.