All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Yi <yi.zhu@intel.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>
Subject: Re: [PATCH 1/2] ipw2100: Register the wiphy device
Date: Thu, 12 Nov 2009 14:19:27 +0800	[thread overview]
Message-ID: <1258006767.31116.53.camel@debian> (raw)
In-Reply-To: <1257968191-495-1-git-send-email-mjg@redhat.com>

On Thu, 2009-11-12 at 03:36 +0800, Matthew Garrett wrote:
> libipw unconditionally calls wiphy_unregister, but it's up to the driver
> to register it in the first place. ipw2100 fails to do so. Add the necessary
> glue code, and also ensure that rfkill statuses get set up appropriately.
> 
> Signed-off-by: Matthew Garrett <mjg@redhat.com>

Acked-by: Zhu Yi <yi.zhu@intel.com>

Thanks for the fix. BTW, have you already tried [1] for the firmware
missing case?

1. http://marc.info/?l=linux-wireless&m=125775901909164&w=2

Thanks,
-yi


  parent reply	other threads:[~2009-11-12  6:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11 19:36 [PATCH 1/2] ipw2100: Register the wiphy device Matthew Garrett
2009-11-11 19:36 ` [PATCH 2/2] ipw2200: Set core hw rfkill status when hardware changes state Matthew Garrett
2009-11-12  6:17   ` Zhu Yi
2009-11-12  6:19 ` Zhu Yi [this message]
2009-11-13  1:16   ` [PATCH 1/2] ipw2100: Register the wiphy device Zhu Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258006767.31116.53.camel@debian \
    --to=yi.zhu@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mjg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.