From: "Figo.zhang" <figo1802@gmail.com>
To: zeal <zealcook@gmail.com>
Cc: netdev@vger.kernel.org, ben@simtec.co.uk, davem@davemloft.net
Subject: Re: [PATCH 1/2 v2] KS8695: fix ks8695_rx_irq() bug.
Date: Fri, 13 Nov 2009 01:11:50 +0800 [thread overview]
Message-ID: <1258045910.1931.16.camel@myhost> (raw)
In-Reply-To: <efc9214f0911160718o4c7cd0ecv2e86b8d5ad7691ae@mail.gmail.com>
On Mon, 2009-11-16 at 23:18 +0800, zeal wrote:
> On Fri, Nov 13, 2009 at 12:24 AM, Figo.zhang <figo1802@gmail.com> wrote:
> > On Mon, 2009-11-16 at 22:58 +0800, zeal wrote:
> >> From: zeal <zealcook@gmail.com>
> >>
> >> Sorry for the previously patches. THEY'RE NOT RIGHT. It's my mistake.
> >> Please forgive my noise.
> >> Please review the following patches and ignore the last (v1).
> >>
> >> ks8695 rx irq is edge-level. Before arriving at irq handler, the
> >> corresponding status bit has been clear(irq's ack).
> >> So we should not check it after that.
> >
> > see <KS8695X Integrated Multi-Port Gateway Solution Register
> > Description> Version 1.00
> >
> > Interrupt Status Register(INTST Offset 0xE208)
> >
> > it has said: This edge-triggered interrupt status is cleared by writting
> > 1 , so we should write 1 to clear status bit manually.
> >
> Yeah, but irq_chip's ack has done that.
> Please check arch/arm/mach-ks8695/irq.c ks8695_irq_edge_chip->ack()
yes, you are right, but you have better add this description at commit
log.
>
> >>
> >> Signed-off-by: zeal <zealcook@gmail.com>
> >> ---
> >> drivers/net/arm/ks8695net.c | 22 +++++++---------------
> >> 1 files changed, 7 insertions(+), 15 deletions(-)
> >>
> >> diff --git a/drivers/net/arm/ks8695net.c b/drivers/net/arm/ks8695net.c
> >> index 0073d19..e15451a 100644
> >> --- a/drivers/net/arm/ks8695net.c
> >> +++ b/drivers/net/arm/ks8695net.c
> >> @@ -433,24 +433,16 @@ ks8695_rx_irq(int irq, void *dev_id)
> >> {
> >> struct net_device *ndev = (struct net_device *)dev_id;
> >> struct ks8695_priv *ksp = netdev_priv(ndev);
> >> - unsigned long status;
> >> -
> >> - unsigned long mask_bit = 1 << ks8695_get_rx_enable_bit(ksp);
> >>
> >> spin_lock(&ksp->rx_lock);
> >>
> >> - status = readl(KS8695_IRQ_VA + KS8695_INTST);
> >> -
> >> - /*clean rx status bit*/
> >> - writel(status | mask_bit , KS8695_IRQ_VA + KS8695_INTST);
> >> -
> >> - if (status & mask_bit) {
> >> - if (napi_schedule_prep(&ksp->napi)) {
> >> - /*disable rx interrupt*/
> >> - status &= ~mask_bit;
> >> - writel(status , KS8695_IRQ_VA + KS8695_INTEN);
> >> - __napi_schedule(&ksp->napi);
> >> - }
> >> + if (napi_schedule_prep(&ksp->napi)) {
> >> + unsigned long status = readl(KS8695_IRQ_VA + KS8695_INTEN);
> >> + unsigned long mask_bit = 1 << ks8695_get_rx_enable_bit(ksp);
> >> + /*disable rx interrupt*/
> >> + status &= ~mask_bit;
> >> + writel(status , KS8695_IRQ_VA + KS8695_INTEN);
> >> + __napi_schedule(&ksp->napi);
> >> }
> >>
> >> spin_unlock(&ksp->rx_lock);
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
>
>
next prev parent reply other threads:[~2009-11-16 15:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 14:58 [PATCH 1/2 v2] KS8695: fix ks8695_rx_irq() bug zeal
2009-11-12 16:24 ` Figo.zhang
2009-11-16 15:18 ` zeal
2009-11-12 17:11 ` Figo.zhang [this message]
2009-11-17 4:28 ` zeal
2009-11-17 7:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258045910.1931.16.camel@myhost \
--to=figo1802@gmail.com \
--cc=ben@simtec.co.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=zealcook@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.