From: Michael 'Mickey' Lauer <mickey@vanille-media.de>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] Precision Time Protocol (PTP) as defined by the IEEE 1588 standard
Date: Thu, 12 Nov 2009 18:19:55 +0100 [thread overview]
Message-ID: <1258046396.13901.4.camel@andromeda> (raw)
In-Reply-To: <1258040941.18126.5.camel@nvc0624>
Hi Jaap,
thanks for your patch.
Some additional style comments:
1.) Please use SOURCEFORGE_MIRROR in SRC_URI
2.) Please use whitespace around the assignment operator
3.) Please check the OE wiki for recommended metadata ordering.
Unfortunately ptpd doesn't build for me. It bails out with:
ERROR: function do_compile failed
ERROR: log data follows
(/local/pkg/oe/om-gta02/tmp/work/armv4t-oe-linux-gnueabi/ptpd-1.0.0-r0/temp/log.do_compile.29312)
| NOTE: make -j3 -e MAKEFLAGS=
| ccache arm-oe-linux-gnueabi-gcc -march=armv4t -mtune=arm920t
-mthumb-interwork -mthumb -c
-isystem/local/pkg/oe/om-gta02/tmp/staging/armv4t-oe-linux-gnueabi/usr/include -fexpensive-optimizations -fomit-frame-pointer -frename-registers -Os -isystem/local/pkg/oe/om-gta02/tmp/staging/armv4t-oe-linux-gnueabi/usr/include -o ptpd.o ptpd.c
| ccache arm-oe-linux-gnueabi-gcc -march=armv4t -mtune=arm920t
-mthumb-interwork -mthumb -c
-isystem/local/pkg/oe/om-gta02/tmp/staging/armv4t-oe-linux-gnueabi/usr/include -fexpensive-optimizations -fomit-frame-pointer -frename-registers -Os -isystem/local/pkg/oe/om-gta02/tmp/staging/armv4t-oe-linux-gnueabi/usr/include -o arith.o arith.c
| ccache arm-oe-linux-gnueabi-gcc -march=armv4t -mtune=arm920t
-mthumb-interwork -mthumb -c
-isystem/local/pkg/oe/om-gta02/tmp/staging/armv4t-oe-linux-gnueabi/usr/include -fexpensive-optimizations -fomit-frame-pointer -frename-registers -Os -isystem/local/pkg/oe/om-gta02/tmp/staging/armv4t-oe-linux-gnueabi/usr/include -o bmc.o bmc.c
| arith.c: In function 'fromInternalTime':
| arith.c:46: error: 'INT_MAX' undeclared (first use in this function)
| arith.c:46: error: (Each undeclared identifier is reported only once
| arith.c:46: error: for each function it appears in.)
| arith.c: In function 'toInternalTime':
| arith.c:64: error: 'INT_MAX' undeclared (first use in this function)
| make: *** [arith.o] Error 1
| make: *** Waiting for unfinished jobs....
| FATAL: oe_runmake failed
Any idea about that?
--
:M:
next prev parent reply other threads:[~2009-11-12 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 15:49 [PATCH] Precision Time Protocol (PTP) as defined by the IEEE 1588 standard Jaap de Jong
2009-11-12 17:04 ` Phil Blundell
2009-11-12 17:19 ` Michael 'Mickey' Lauer [this message]
2009-11-13 10:34 ` Jaap de Jong
-- strict thread matches above, loose matches on Subject: below --
2009-11-09 12:50 Jaap de Jong
2009-11-09 14:13 ` Michael Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258046396.13901.4.camel@andromeda \
--to=mickey@vanille-media.de \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.