All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Janakiram Sistla <janakiram.sistla@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch 0/1] Adding radio type FM
Date: Sat, 14 Nov 2009 19:05:09 +0100	[thread overview]
Message-ID: <1258221909.3299.26.camel@violet> (raw)
In-Reply-To: <4fb5db50911140937j278584e5nf9e4d5767a44a920@mail.gmail.com>

Hi Janakiram,

> I thought i would see the change first in include/linux/rfkill.h
> getting accepted and then i can add the change in core.c also.
> 
> Let me know if i can push both in the same patch.

I said that you can add RFKILL_TYPE_FM to the RFKILL subsystem, but the
input changes might not be the right ones. Since eventually the
in-kernel input support will be removed.

And I did ask if the FM button you see is a generic RFKILL toggle or a
FM specific button. Especially since you had a copy-and-paste mistake in
your patches, that code path clearly was never tested by you.

Regards

Marcel



  reply	other threads:[~2009-11-14 18:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13  3:09 [patch 0/1] Adding radio type FM Janakiram Sistla
2009-11-13  3:09 ` John W. Linville
2009-11-13  3:25   ` Janakiram Sistla
2009-11-13  3:29     ` Julian Calaby
2009-11-13  3:41       ` Marcel Holtmann
2009-11-13  3:45         ` Julian Calaby
2009-11-13  5:19           ` Janakiram Sistla
2009-11-13  5:30             ` Marcel Holtmann
2009-11-13  3:22 ` Marcel Holtmann
2009-11-13  5:32   ` Janakiram Sistla
2009-11-13 18:19     ` Janakiram Sistla
2009-11-14 13:19   ` Janakiram Sistla
2009-11-14 16:34     ` Marcel Holtmann
2009-11-14 17:37       ` Janakiram Sistla
2009-11-14 18:05         ` Marcel Holtmann [this message]
2009-11-16  2:36           ` [PATCH 1/1] " Janakiram Sistla
2009-11-16  2:43             ` Marcel Holtmann
2009-11-16  4:25               ` Janakiram Sistla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258221909.3299.26.camel@violet \
    --to=marcel@holtmann.org \
    --cc=janakiram.sistla@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.