From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N9PuH-0006b4-Ne for mharc-grub-devel@gnu.org; Sat, 14 Nov 2009 16:11:41 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N9PuG-0006az-DM for grub-devel@gnu.org; Sat, 14 Nov 2009 16:11:40 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N9PuB-0006Zv-Tz for grub-devel@gnu.org; Sat, 14 Nov 2009 16:11:40 -0500 Received: from [199.232.76.173] (port=33067 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N9PuB-0006Zs-Ox for grub-devel@gnu.org; Sat, 14 Nov 2009 16:11:35 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:64639) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N9PuB-0005t1-8U for grub-devel@gnu.org; Sat, 14 Nov 2009 16:11:35 -0500 Received: from [85.180.1.205] (e180001205.adsl.alicedsl.de [85.180.1.205]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0MZOd3-1MoIYL15HZ-00LkdX; Sat, 14 Nov 2009 22:11:32 +0100 From: Felix Zielcke To: The development of GNU GRUB In-Reply-To: <20091114153519.GA7084@thorin> References: <1258058194.4779.6.camel@fz.local> <4AFDE128.6050408@gmail.com> <20091114153519.GA7084@thorin> Content-Type: text/plain; charset="UTF-8" Date: Sat, 14 Nov 2009 22:11:31 +0100 Message-ID: <1258233091.2749.2.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/y3urpeiBCrOqGlm5QrtYO0ciOKnut1n55ffn h4dSR0YbyV1arJvkt7VTTBDLUT3xmlbsbzq0b6LsgRLou5Sutz wyVWNp0eHLddxZUdAfPMwvWF2wbCN4q X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Re: Bug in read_handler_list (autoloading) ??? X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2009 21:11:40 -0000 Am Samstag, den 14.11.2009, 16:35 +0100 schrieb Robert Millan: > On Fri, Nov 13, 2009 at 11:43:52PM +0100, Vladimir 'phcoder' Serbinenko wrote: > > Felix Zielcke wrote: > > > Am Donnerstag, den 12.11.2009, 21:46 +0530 schrieb BVK: > > > > > >> Valgrind log is attached. It also reported invalid free for the same place. > > >> > > >> BTW, valgrind is run as > > >> > > >> sudo valgrind -v --log-file=/tmp/valgrind.log ./grub-emu > > >> > > > > > > Here's a grub-emu tested patch to fix this > > > > > > > > > > > Why are all handlers are removed on normal.mod unload? If user e.g. > > relies on special terminal he may lose terminal completely. I would say > > it's better not to touch already loaded modules. I temporarily unmerged > > it from experimental. We can remerge it once issues are fixed > > Did you unmerge Felix' fix, or the original prefix move fix? I didn't commit my fix. He reverted your original merge of this. > My goal was to make command and file-system auto-completion not break when > $prefix is changed. Handlers are not the important change in my initial > patch, and if it's problematic it can be discarded IMO. > -- Felix Zielcke Proud Debian Maintainer and GNU GRUB developer