From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N9d96-00016J-BN for mharc-grub-devel@gnu.org; Sun, 15 Nov 2009 06:19:52 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N9d94-000153-1S for grub-devel@gnu.org; Sun, 15 Nov 2009 06:19:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N9d8z-00011a-90 for grub-devel@gnu.org; Sun, 15 Nov 2009 06:19:49 -0500 Received: from [199.232.76.173] (port=54376 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N9d8y-00011U-T5 for grub-devel@gnu.org; Sun, 15 Nov 2009 06:19:44 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:64532) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N9d8y-0004EG-9J for grub-devel@gnu.org; Sun, 15 Nov 2009 06:19:44 -0500 Received: from [85.180.43.63] (e180043063.adsl.alicedsl.de [85.180.43.63]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0Lqn9W-1MVMNh1dfG-00dpMm; Sun, 15 Nov 2009 12:19:43 +0100 From: Felix Zielcke To: The development of GNU GRUB In-Reply-To: <20091115111251.GC25752@thorin> References: <20091026161638.GA9371@thorin> <20091028231622.GA19287@thorin> <20091029101433.GA8145@thorin> <20091029103618.GA10006@thorin> <1257331694.5000.34.camel@fz.local> <1258233405.2749.8.camel@fz.local> <20091115110458.GA25752@thorin> <20091115111251.GC25752@thorin> Content-Type: text/plain; charset="UTF-8" Date: Sun, 15 Nov 2009 12:19:42 +0100 Message-ID: <1258283982.2822.9.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1+LHVT0R6+z5nriZUHr4VowD4BjwtdqeAryMwT MDyYVALPNHMW1UZ/XrVEqvvr/N7tNEe6C+E+ZvzXOyPy2DsLUt AlOX2FEQq4FkwtLEg90FS+QkhFdQL2k X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Add -nostdinc to TARGET_CFLAGS X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Nov 2009 11:19:50 -0000 Am Sonntag, den 15.11.2009, 12:12 +0100 schrieb Robert Millan: > On Sun, Nov 15, 2009 at 12:04:58PM +0100, Robert Millan wrote: > > On Sat, Nov 14, 2009 at 10:16:45PM +0100, Felix Zielcke wrote: > > > Am Mittwoch, den 04.11.2009, 11:48 +0100 schrieb Felix Zielcke: > > > > > > > > Thanks to the hint from rubisher I looked now at Linux Makefiles. > > > > They use this: > > > > > > > > NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-file-name=include) > > > > > > > > # ls $(gcc-4.4 -print-file-name=include)/stdarg.h > > > > /usr/lib/gcc/x86_64-linux-gnu/4.4.2/include/stdarg.h > > > > > > > > > > Robert? > > > IMO this makes at least more sense then what we have now > > > and I just tested this now with and without a seperate build directory > > > with experimental branch and it works > > > TARGET_CPPFLAGS = @TARGET_CPPFLAGS@ -nostdinc -isystem $(shell $(CC) > > > -print-file-name=include) -I$(srcdir)/include -I$(builddir) > > > -I$(builddir)/include -Wall -W > > > > What's the advantage? > > Ah, I remember. There was a problem with stddef.h right? > > So you propose something like this: > > -TARGET_CPPFLAGS = @TARGET_CPPFLAGS@ -isystem=$(srcdir)/include -I$(srcdir)/include -I$(builddir) -I$(builddir)/include \ > +TARGET_CPPFLAGS = @TARGET_CPPFLAGS@ -isystem=$(shell $(CC) -print-file-name=include) -I$(srcdir)/include -I$(builddir) -I$(builddir)/include \ > > ? See my previous mail, actually this: -TARGET_CPPFLAGS = @TARGET_CPPFLAGS@ -isystem=$(srcdir)/include -I$(srcdir)/include -I$(builddir) -I$(builddir)/include \ +TARGET_CPPFLAGS = @TARGET_CPPFLAGS@ -nostdinc -isystem $(shell $(CC) -print-file-name=include) -I$(srcdir)/include -I$(builddir) -I$(builddir)/include \ The = in -isystem doestn't make much sense to me. And with above -nostdinc really works for us. -- Felix Zielcke Proud Debian Maintainer and GNU GRUB developer