From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Add -nostdinc to TARGET_CFLAGS
Date: Sun, 15 Nov 2009 13:42:56 +0100 [thread overview]
Message-ID: <1258288976.2822.13.camel@fz.local> (raw)
In-Reply-To: <20091115123207.GA26645@thorin>
Am Sonntag, den 15.11.2009, 13:32 +0100 schrieb Robert Millan:
> On Sun, Nov 15, 2009 at 12:50:39PM +0100, Felix Zielcke wrote:
> > > > $ srcdir=$PWD builddir=$PWD gcc -isystem=$srcdir/include -I$srcdir/include -I$builddir -I$builddir/include test.c -o test && ls test
> > > > test
> > > > $ srcdir=$PWD builddir=$PWD gcc -nostdinc -isystem $(gcc -print-file-name=include) -I$srcdir/include -I$builddir -I$builddir/include test.c
> > > > test.c:2:20: error: stdint.h: No such file or directory
> > >
> > > We used -isystem as a way of excluding system headers but not gcc headers.
> > > With the -print-file-name trick this seems to be no longer necessary, right?
> > >
> > > So why not "-nostdinc -I$(gcc -print-file-name=include)" instead?
> >
> > I think we should use -isystem for the gcc internal header files not -I,
> > but I just tested experimental branch with -I instead of -isystem and
> > also compiles cleanly (except the usual grub.texi warnings)
>
> Seems fine. Thanks for investigating this.
You're welcome.
I commited this now except that I used now $TARGET_CC.
Makes more sense inside TARGET_CPPFLAGS.
--
Felix Zielcke
Proud Debian Maintainer and GNU GRUB developer
prev parent reply other threads:[~2009-11-15 12:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 16:16 [PATCH] Add -nostdinc to TARGET_CFLAGS Robert Millan
2009-10-28 23:16 ` Robert Millan
2009-10-29 10:14 ` Robert Millan
2009-10-29 10:36 ` Robert Millan
2009-10-29 10:46 ` Vladimir 'phcoder' Serbinenko
2009-10-30 18:55 ` Robert Millan
2009-11-04 10:48 ` Felix Zielcke
2009-11-14 21:16 ` Felix Zielcke
2009-11-15 11:04 ` Robert Millan
2009-11-15 11:12 ` Robert Millan
2009-11-15 11:19 ` Felix Zielcke
2009-11-15 11:17 ` Felix Zielcke
2009-11-15 11:35 ` Robert Millan
2009-11-15 11:50 ` Felix Zielcke
2009-11-15 12:32 ` Robert Millan
2009-11-15 12:42 ` Felix Zielcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258288976.2822.13.camel@fz.local \
--to=fzielcke@z-51.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.