All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@fifo99.com>
To: Alexey Starikovskiy <aystarik@gmail.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
	Len Brown <len.brown@intel.com>, Lin Ming <ming.m.lin@intel.com>,
	Bob Moore <robert.moore@intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/5] acpi: fix trivial warning
Date: Sun, 15 Nov 2009 09:58:35 -0800	[thread overview]
Message-ID: <1258307915.6428.14.camel@desktop> (raw)
In-Reply-To: <4B00403E.3090907@gmail.com>

On Sun, 2009-11-15 at 20:54 +0300, Alexey Starikovskiy wrote:
> You've made changes to automatically generated files, so all the style 
> changes
> would be overwritten when next time these files are generated -- all the 
> files go through
> Lindent, and almost all your changes were introduced by it. If you 
> really want to make
> style changes to ACPICA files, try to play with Lindent, so it produce 
> what you want.
> If you have anything beside style patches, please submit them separately
> 

AFAIK, Lindent can't produce checkpatch clean output. It has to do with
various short comings in indent. You really need a human to check up on
it.

Daniel


  reply	other threads:[~2009-11-15 18:00 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-13 19:38 [PATCH 0/5] Trivial warning cleanups Felipe Contreras
2009-09-13 19:38 ` [PATCH 1/5] Trivial whitespace cleanups Felipe Contreras
2009-09-13 19:38   ` [PATCH 2/5] kbuild: fix warning when domainname is not available Felipe Contreras
2009-09-13 19:38     ` [PATCH 3/5] kbuild: mkcompile_h: trivial cleanups Felipe Contreras
2009-09-13 19:38       ` [PATCH 4/5] acpi: fix trivial warning Felipe Contreras
2009-09-13 19:38         ` Felipe Contreras
2009-09-13 19:38         ` [PATCH 5/5] acpi: fix trivial warnings caused by previous commmit Felipe Contreras
2009-09-14 13:55         ` [PATCH 4/5] acpi: fix trivial warning Daniel Walker
2009-09-14 13:55           ` Daniel Walker
2009-09-14 14:34           ` Felipe Contreras
2009-09-14 14:34             ` Felipe Contreras
2009-09-14 15:02             ` Daniel Walker
2009-09-14 15:02               ` Daniel Walker
2009-11-12  0:23               ` Felipe Contreras
2009-11-13 17:43                 ` Daniel Walker
2009-11-13 20:28                   ` Felipe Contreras
2009-11-13 20:37                     ` Thiago Farina
2009-11-15 17:15                     ` Daniel Walker
2009-11-15 17:27                       ` Felipe Contreras
2009-11-15 17:32                         ` Daniel Walker
2009-11-15 17:54                           ` Alexey Starikovskiy
2009-11-15 17:58                             ` Daniel Walker [this message]
2009-11-15 18:10                               ` Alexey Starikovskiy
2009-11-15 18:09                                 ` Daniel Walker
2009-11-16  1:27                         ` Lin Ming
2009-09-13 21:12     ` [PATCH 2/5] kbuild: fix warning when domainname is not available Mike Frysinger
2009-09-13 21:42       ` Felipe Contreras
2009-09-13 21:58         ` Mike Frysinger
2009-09-13 22:04           ` Felipe Contreras
2009-09-14  4:46             ` Sam Ravnborg
2009-09-14  8:25               ` Felipe Contreras
2009-09-14 13:43                 ` Mike Frysinger
2009-09-15  8:38                   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258307915.6428.14.camel@desktop \
    --to=dwalker@fifo99.com \
    --cc=ak@linux.intel.com \
    --cc=aystarik@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=len.brown@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.