From: Sverre Rabbelier <srabbelier@gmail.com>
To: Git List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Daniel Barkalow <barkalow@iabervon.org>,
Johan Herland <johan@herland.net>
Cc: Daniel Barkalow <barkalow@iabervon.org>
Subject: [PATCH v4 01/12] Fix memory leak in helper method for disconnect
Date: Wed, 18 Nov 2009 02:42:21 +0100 [thread overview]
Message-ID: <1258508552-20752-2-git-send-email-srabbelier@gmail.com> (raw)
In-Reply-To: <1258508552-20752-1-git-send-email-srabbelier@gmail.com>
From: Daniel Barkalow <barkalow@iabervon.org>
Since some cases may need to disconnect from the helper and reconnect,
wrap the function that just disconnects in a function that also frees
transport->data.
Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
---
Unchanged.
transport-helper.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index f57e84c..e24fcbb 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -67,6 +67,13 @@ static int disconnect_helper(struct transport *transport)
return 0;
}
+static int release_helper(struct transport *transport)
+{
+ disconnect_helper(transport);
+ free(transport->data);
+ return 0;
+}
+
static int fetch_with_fetch(struct transport *transport,
int nr_heads, const struct ref **to_fetch)
{
@@ -163,6 +170,6 @@ int transport_helper_init(struct transport *transport, const char *name)
transport->data = data;
transport->get_refs_list = get_refs_list;
transport->fetch = fetch;
- transport->disconnect = disconnect_helper;
+ transport->disconnect = release_helper;
return 0;
}
--
1.6.5.3.164.g07b0c
next prev parent reply other threads:[~2009-11-18 1:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 1:42 [PATCH v4 00/12] Reroll of the remote-vcs-helper series Sverre Rabbelier
2009-11-18 1:42 ` Sverre Rabbelier [this message]
2009-11-18 1:42 ` [PATCH v4 02/12] Allow programs to not depend on remotes having urls Sverre Rabbelier
2009-11-18 1:42 ` [PATCH v4 03/12] Use a function to determine whether a remote is valid Sverre Rabbelier
2009-11-18 1:42 ` [PATCH v4 04/12] Allow fetch to modify refs Sverre Rabbelier
2009-11-18 1:42 ` [PATCH v4 05/12] Add a config option for remotes to specify a foreign vcs Sverre Rabbelier
2009-11-18 1:42 ` [PATCH v4 06/12] Allow specifying the remote helper in the url Sverre Rabbelier
2009-11-18 1:42 ` [PATCH v4 07/12] Add support for "import" helper command Sverre Rabbelier
2009-11-18 1:42 ` [PATCH v4 08/12] Allow helper to map private ref names into normal names Sverre Rabbelier
2009-11-18 1:42 ` [PATCH v4 09/12] Fix various memory leaks in transport-helper.c Sverre Rabbelier
2009-11-18 1:42 ` [PATCH v4 10/12] Allow helpers to report in "list" command that the ref is unchanged Sverre Rabbelier
2009-11-18 1:42 ` [PATCH v4 11/12] Basic build infrastructure for Python scripts Sverre Rabbelier
2009-11-18 1:42 ` [PATCH v4 12/12] Add Python support library for remote helpers Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258508552-20752-2-git-send-email-srabbelier@gmail.com \
--to=srabbelier@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.