Re: [PATCH v2] eal: choose IOVA mode according to compilation flags

[Thomas Monjalon <thomas@monjalon.net>]

06/06/2023 17:23, Bruce Richardson:
> On Tue, Jun 06, 2023 at 06:15:11PM +0300, Viacheslav Ovsiienko wrote:
> > The DPDK can be compiled to be run in IOVA VA mode with
> > 'enable_iova_as_pa=false' meson option. If there is no
> > explicit EAL --iova-mode parameter specified in the command
> > line the rte_eal_init() tried to deduce VA or PA mode without
> > taking into account the above mentioned compile time option,
> > resulting into initialization failure.

It looks like a bug fix to backport. Do you agree?
Could you add the fix tags?

> > 
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

You forgot previous tag:
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>

> > ---
> >  lib/eal/linux/eal.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)

What about FreeBSD and Windows?
I suspect there is the same issue.

> > @@ -1081,7 +1081,10 @@ rte_eal_init(int argc, char **argv)
> >  		if (iova_mode == RTE_IOVA_DC) {
> >  			RTE_LOG(DEBUG, EAL, "Buses did not request a specific IOVA mode.\n");
> >  
> > -			if (!phys_addrs) {
> > +			if (!RTE_IOVA_IN_MBUF) {
> > +				iova_mode = RTE_IOVA_VA;
> > +				RTE_LOG(DEBUG, EAL, "IOVA as VA mode is forced by build option.\n");
> > +			} else if (!phys_addrs) {
> >  				/* if we have no access to physical addresses,
> >  				 * pick IOVA as VA mode.
> >  				 */
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>